Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(684)

Issue 7499043: state/apiserver: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by rog
Modified:
6 years, 10 months ago
Reviewers:
dimitern, mp+151848, TheMue
Visibility:
Public.

Description

state/apiserver: new package This is necessary to break the import cycle that happens when the api server imports launchpad.net/juju. This change is purely mechanical - no logic changes. https://code.launchpad.net/~rogpeppe/juju-core/237-clientserver/+merge/151848 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: new package #

Patch Set 3 : state/apiserver: new package #

Total comments: 2

Patch Set 4 : state/apiserver: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+837 lines, -822 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/dummy/environs.go View 3 chunks +3 lines, -2 lines 0 comments Download
M state/api/apiclient.go View 1 2 7 chunks +40 lines, -6 lines 0 comments Download
D state/api/apiserver.go View 1 chunk +0 lines, -527 lines 0 comments Download
M state/api/client.go View 1 chunk +7 lines, -0 lines 0 comments Download
M state/api/error.go View 3 chunks +0 lines, -44 lines 0 comments Download
D state/api/export_test.go View 1 chunk +0 lines, -20 lines 0 comments Download
D state/api/server.go View 1 chunk +0 lines, -203 lines 0 comments Download
M state/apiserver/api_test.go View 8 chunks +19 lines, -18 lines 0 comments Download
A state/apiserver/apiserver.go View 1 2 1 chunk +501 lines, -0 lines 0 comments Download
A state/apiserver/error.go View 1 chunk +49 lines, -0 lines 0 comments Download
A state/apiserver/export_test.go View 1 chunk +11 lines, -0 lines 0 comments Download
A state/apiserver/server.go View 1 chunk +203 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
6 years, 10 months ago (2013-03-05 22:56:18 UTC) #1
rog
Please take a look.
6 years, 10 months ago (2013-03-06 11:46:58 UTC) #2
dimitern
LGTM, although I'd like to see better doc comments for RPC* structs (if relevant).
6 years, 10 months ago (2013-03-06 14:10:03 UTC) #3
TheMue
LGTM, only minor comments. https://codereview.appspot.com/7499043/diff/5001/state/api/apiclient.go File state/api/apiclient.go (right): https://codereview.appspot.com/7499043/diff/5001/state/api/apiclient.go#newcode328 state/api/apiclient.go:328: // RPCCreds is used in ...
6 years, 10 months ago (2013-03-06 14:24:13 UTC) #4
rog
I started documenting the RPC structs but really, they're not useful except in conjunction with ...
6 years, 10 months ago (2013-03-06 14:32:13 UTC) #5
rog
6 years, 10 months ago (2013-03-06 14:46:00 UTC) #6
*** Submitted:

state/apiserver: new package

This is necessary to break the import cycle that happens
when the api server imports launchpad.net/juju.

This change is purely mechanical - no logic changes.

R=dimitern, TheMue
CC=
https://codereview.appspot.com/7499043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b