state/apiserver: new package

state/apiserver: new package

This is necessary to break the import cycle that happens
when the api server imports launchpad.net/juju.

This change is purely mechanical - no logic changes.

https://code.launchpad.net/~rogpeppe/juju-core/237-clientserver/+merge/151848

(do not edit description out of merge proposal)

[rog, 2013-03-05 22:56:18]

Please take a look.

[rog, 2013-03-06 11:46:58]

Please take a look.

[dimitern, 2013-03-06 14:10:03]

LGTM, although I'd like to see better doc comments for RPC* structs (if
relevant).

[TheMue, 2013-03-06 14:24:13]

LGTM, only minor comments.

https://codereview.appspot.com/7499043/diff/5001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/7499043/diff/5001/state/api/apiclient.go#newco...
state/api/apiclient.go:328: // RPCCreds is used in the API protocol.
What are the semantics behind those structs used in the API protocol?

https://codereview.appspot.com/7499043/diff/5001/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/7499043/diff/5001/state/apiserver/api_test.go#...
state/apiserver/api_test.go:1: package apiserver_test
Nothing important, but would like the file to be renamed to server_test.go or
apiserver_test.go to be more consistent.

[rog, 2013-03-06 14:32:13]

I started documenting the RPC structs but really, they're not useful except in
conjunction with the API protocol docs (which don't exist yet). All I ended up
doing was saying, for example, RPCCreds holds credentials for the Admin.Login
RPC call - but Admin.Login isn't mentioned anywhere else. Really, they'd be
unexported but for the import loop.

> Nothing important, but would like the file to be renamed to
> server_test.go or apiserver_test.go to be more consistent.

Actually it is testing the api client, so api_test seems appropriate to me.

[rog, 2013-03-06 14:46:00]

*** Submitted:

state/apiserver: new package

This is necessary to break the import cycle that happens
when the api server imports launchpad.net/juju.

This change is purely mechanical - no logic changes.

R=dimitern, TheMue
CC=
https://codereview.appspot.com/7499043