code review 7497045: go.exp: Add fsnotify package

go.exp: Add fsnotify package

Previous discussions:
https://codereview.appspot.com/5585043/
https://code.google.com/p/go/issues/detail?id=4068

[howeyc, 2013-03-11 17:10:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.exp

[rsc, 2013-03-11 17:23:18]

Thanks. I'd like to try to make the API more uniform, so that it's hard to write
code that accidentally uses a piece of the API that's only available on, say,
Linux, but we can do that in followup CLs.

https://codereview.appspot.com/7497045/diff/7001/fsnotify/example_test.go
File fsnotify/example_test.go (right):

https://codereview.appspot.com/7497045/diff/7001/fsnotify/example_test.go#new...
fsnotify/example_test.go:1: package fsnotify_test
insert copyright notice

https://codereview.appspot.com/7497045/diff/7001/fsnotify/example_test.go#new...
fsnotify/example_test.go:4: "code.google.com/p/go.exp/fsnotify"
please use

import (
   "log"

   "code.google.com/p/go.exp/fsnotify"
)

with a blank line separating standard imports from 'go get' imports.

https://codereview.appspot.com/7497045/diff/7001/fsnotify/fsnotify_bsd.go
File fsnotify/fsnotify_bsd.go (right):

https://codereview.appspot.com/7497045/diff/7001/fsnotify/fsnotify_bsd.go#new...
fsnotify/fsnotify_bsd.go:7: //Package fsnotify implements filesystem
notification.
better to move the doc comments into a single file that gets used always, like
fsnotify.go, or else a new doc.go.

[howeyc, 2013-03-11 17:45:09]

I've made changes based on your feedback.

[rsc, 2013-03-11 20:28:00]

https://codereview.appspot.com/7497045/diff/11001/fsnotify/fsnotify.go
File fsnotify/fsnotify.go (right):

https://codereview.appspot.com/7497045/diff/11001/fsnotify/fsnotify.go#newcode5
fsnotify/fsnotify.go:5: //Package fsnotify implements filesystem notification.
please put a space after the // and we're good to go.

[howeyc, 2013-03-11 21:12:04]

updated.

[rsc, 2013-03-11 22:07:55]

*** Submitted as
https://code.google.com/p/go/source/detail?r=aa678ea78eb7&repo=exp ***

go.exp: Add fsnotify package

Previous discussions:
https://codereview.appspot.com/5585043/
https://code.google.com/p/go/issues/detail?id=4068

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7497045

Committer: Russ Cox <rsc@golang.org>

[rsc, 2013-03-11 22:08:07]

LGTM

I changed TestSubDir to skip the test, because it was failing on my Mac.

[brainman, 2013-03-14 06:39:04]

This change breaks go.exp repo windows build. This

exec.Command("mv", testFile, testFileRenamed)

(in test), will not work on windows. What is the plan here?

Thank you.

Alex

[remyoudompheng, 2013-07-21 10:21:21]

R=close