Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(453)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7496047: Api 686: Mark some parts of library as Experimental (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by peleyal
Modified:
13 years, 7 months ago
Reviewers:
yanivi
CC:
ngmiceli
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

Api 686: Mark some parts of library as Experimental

Patch Set 1 #

Total comments: 10

Patch Set 2 : Yanivi comments #

Patch Set 3 : Small fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -74 lines) Patch
M findbugs-exclude.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/accounts/GoogleAccountManager.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/accounts/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java View 1 4 chunks +4 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAuthIOException.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GooglePlayServicesAvailabilityIOException.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/UserRecoverableAuthIOException.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java View 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java View 1 5 chunks +6 lines, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java View 1 2 chunks +3 lines, -0 lines 1 comment Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/AbstractWebHookServlet.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/JdoSubscriptionStore.java View 1 4 chunks +4 lines, -0 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/WebHookDeliveryMethod.java View 1 3 chunks +5 lines, -2 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/GoogleHeaders.java View 1 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUrl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/AuthKeyValueParser.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLoginResponseException.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeFlow.java View 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 4 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdToken.java View 1 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenVerifier.java View 15 chunks +15 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleTokenResponse.java View 1 4 chunks +7 lines, -4 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonCContent.java View 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonCParser.java View 2 chunks +2 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClient.java View 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java View 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/json/AbstractGoogleJsonClient.java View 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/EventTypes.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/MemorySubscriptionStore.java View 1 3 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Notification.java View 1 2 chunks +3 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationCallback.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java View 1 1 chunk +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/StoredSubscription.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionStore.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotification.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotificationCallback.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/UnparsedNotification.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/JsonNotificationCallback.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/package-info.java View 1 1 chunk +2 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/MockGoogleClient.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/MockGoogleClientRequest.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/json/MockGoogleJsonClient.java View 1 2 chunks +5 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/json/MockGoogleJsonClientRequest.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/json/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/services/package-info.java View 1 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/MockNotificationCallback.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/package-info.java View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/AtomPatchContent.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/AtomPatchRelativeToOriginalContent.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/GoogleAtom.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/MultiKindFeedParser.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/package-info.java View 1 3 chunks +4 lines, -7 lines 0 comments Download
M pom.xml View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
peleyal
13 years, 7 months ago (2013-03-06 21:08:21 UTC) #1
yanivi
same comments as http project https://codereview.appspot.com/7496047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java File google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java (right): https://codereview.appspot.com/7496047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#newcode211 google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java:211: @Experimental package private https://codereview.appspot.com/7496047/diff/1/google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/JdoSubscriptionStore.java ...
13 years, 7 months ago (2013-03-07 20:59:33 UTC) #2
peleyal
https://codereview.appspot.com/7496047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java File google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java (right): https://codereview.appspot.com/7496047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#newcode211 google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java:211: @Experimental I prefer to leave it as it is, ...
13 years, 7 months ago (2013-03-08 18:53:49 UTC) #3
yanivi
LGTM https://codereview.appspot.com/7496047/diff/19004/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java (left): https://codereview.appspot.com/7496047/diff/19004/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java#oldcode17 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java:17: import com.google.api.client.googleapis.extensions.servlet.subscriptions.AbstractWebHookServlet; please hg pull -u because this ...
13 years, 7 months ago (2013-03-13 02:37:14 UTC) #4
peleyal
13 years, 7 months ago (2013-03-13 15:13:51 UTC) #5
Message was sent while issue was closed. 
On 2013/03/13 02:37:14, yanivi wrote:
> LGTM
> 
>
https://codereview.appspot.com/7496047/diff/19004/google-api-client-appengine...
> File
>
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java
> (left):
> 
>
https://codereview.appspot.com/7496047/diff/19004/google-api-client-appengine...
>
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java:17:
> import
>
com.google.api.client.googleapis.extensions.servlet.subscriptions.AbstractWebHookServlet;
> please hg pull -u because this file was deleted.

DONE
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b