LGTMoi https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils_test.py File endpoints_proto_datastore/utils_test.py (right): https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils_test.py#newcode28 endpoints_proto_datastore/utils_test.py:28: # Make sure this does not fail Isn't ...
13 years, 6 months ago
(2013-03-18 18:24:22 UTC)
#2
FYI: I'm not quite done with this yet, so maybe you want to un-LGTM it? ...
13 years, 6 months ago
(2013-03-18 18:29:09 UTC)
#3
FYI:
I'm not quite done with this yet, so maybe you want to un-LGTM it?
I want to add a test runner that will "just work" in most cases.
https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils...
File endpoints_proto_datastore/utils_test.py (right):
https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils...
endpoints_proto_datastore/utils_test.py:28: # Make sure this does not fail
Maybe? It's the point of overriding the default behavior of issubclass (from the
stdlib).
>>> issubclass(int, None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: issubclass() arg 2 must be a class or tuple of classes
On 2013/03/18 18:24:22, danielholevoet wrote:
> Isn't this comment unnecessary?
Issue 7494047: Adding basic tests for shared utils.
(Closed)
Created 13 years, 7 months ago by dhermes
Modified 13 years, 6 months ago
Reviewers: danielholevoet
Base URL:
Comments: 2