Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 7494047: Adding basic tests for shared utils. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by dhermes
Modified:
13 years, 6 months ago
Reviewers:
danielholevoet
CC:
fredsa.google
Visibility:
Public.

Description

Adding basic tests for shared utils.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test runner for "any" environment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A endpoints_proto_datastore/utils_test.py View 1 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dhermes
13 years, 7 months ago (2013-03-17 21:44:27 UTC) #1
danielholevoet
LGTMoi https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils_test.py File endpoints_proto_datastore/utils_test.py (right): https://codereview.appspot.com/7494047/diff/1/endpoints_proto_datastore/utils_test.py#newcode28 endpoints_proto_datastore/utils_test.py:28: # Make sure this does not fail Isn't ...
13 years, 6 months ago (2013-03-18 18:24:22 UTC) #2
dhermes
FYI: I'm not quite done with this yet, so maybe you want to un-LGTM it? ...
13 years, 6 months ago (2013-03-18 18:29:09 UTC) #3
danielholevoet
Not sure how to un-LGTMoi. Just let me know when the rest is there and ...
13 years, 6 months ago (2013-03-18 18:30:31 UTC) #4
dhermes
Test runner for "any" environment.
13 years, 6 months ago (2013-03-21 21:29:49 UTC) #5
danielholevoet
On 2013/03/21 21:29:49, dhermes wrote: > Test runner for "any" environment. LGTM++
13 years, 6 months ago (2013-03-21 21:49:14 UTC) #6
dhermes
13 years, 6 months ago (2013-03-21 21:50:49 UTC) #7

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b