Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1075)

Issue 7493044: code review 7493044: undo CL 7301062 / 9742f722b558 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

undo CL 7301062 / 9742f722b558 broke arm garbage collector traceback_arm fails with a missing pc. It needs CL 7494043. But that only makes the build break later, this time with "invalid freelist". Roll back until it can be fixed correctly. ««« original CL description runtime: restrict stack root scan to locals and arguments R=rsc CC=golang-dev https://codereview.appspot.com/7301062 »»»

Patch Set 1 #

Patch Set 2 : diff -r 37ff8fa97bb8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 37ff8fa97bb8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -77 lines) Patch
M src/pkg/runtime/mgc0.c View 1 1 chunk +29 lines, -30 lines 0 comments Download
M src/pkg/runtime/mprof.goc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/proc.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sigqueue.goc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 10 chunks +10 lines, -19 lines 0 comments Download
M src/pkg/runtime/traceback_x86.c View 1 10 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2013-03-05 20:33:03 UTC) #1
bradfitz
LGTM On Tue, Mar 5, 2013 at 12:33 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
12 years, 1 month ago (2013-03-05 20:33:37 UTC) #2
rsc
12 years, 1 month ago (2013-03-05 20:36:43 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=866f0a07de2d ***

undo CL 7301062 / 9742f722b558

broke arm garbage collector

traceback_arm fails with a missing pc. It needs CL 7494043.
But that only makes the build break later, this time with
"invalid freelist". Roll back until it can be fixed correctly.

««« original CL description
runtime: restrict stack root scan to locals and arguments

R=rsc
CC=golang-dev
https://codereview.appspot.com/7301062
»»»

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7493044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b