Issue 7486053: code review 7486053: cmd/ld: another use-after-free

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7486053: code review 7486053: cmd/ld: another use-after-free (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:
dave

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/ld: another use-after-free This only shows up in the duplicate symbol error message.

Patch Set 1 #

Patch Set 2 : diff -r 376f233efcc0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 74da57c3abfe https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9d23267675ef https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
M	src/cmd/5l/obj.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6l/obj.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8l/obj.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2013-03-14 18:21:53 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=77e6fc536a7d *** cmd/ld: another use-after-free This only shows up in the duplicate ...

12 years, 2 months ago (2013-03-14 18:35:52 UTC) #3

dave_cheney.net

12 years, 2 months ago (2013-03-14 20:59:07 UTC) #4

Was this detected with a tool, or via code inspection ?

On Fri, Mar 15, 2013 at 5:35 AM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=77e6fc536a7d ***
>
>
> cmd/ld: another use-after-free
>
> This only shows up in the duplicate symbol error message.
>
> R=golang-dev, r
> CC=golang-dev
> https://codereview.appspot.com/7486053
>
>
>
> https://codereview.appspot.com/7486053/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages