Issue 7481048: cmd/jujud: register providers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7481048: cmd/jujud: register providers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dave

Modified:
11 years, 2 months ago

Reviewers:
mp+152537

Visibility:
Public.

Description

cmd/jujud: register providers Somehow we managed to not import the ec2 and openstack providers. Fixed and added a test so we can't make this mistake again. https://code.launchpad.net/~dave-cheney/juju-core/105-import-ec2-provider-into-jujud/+merge/152537 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: register providers #

Total comments: 1

Patch Set 3 : cmd/jujud: register providers #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/main.go	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	cmd/jujud/main_test.go	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/7481048/diff/3001/cmd/jujud/main.go File cmd/jujud/main.go (right): https://codereview.appspot.com/7481048/diff/3001/cmd/jujud/main.go#newcode14 cmd/jujud/main.go:14: // be available to the juju command. s/juju/jujud/

11 years, 2 months ago (2013-03-08 23:39:06 UTC) #3

dave_cheney.net

11 years, 2 months ago (2013-03-08 23:41:08 UTC) #5

*** Submitted:

cmd/jujud: register providers

Somehow we managed to not import the ec2 and openstack providers. Fixed and
added a test so we can't make this mistake again.

R=rog, gz
CC=
https://codereview.appspot.com/7481048

Expand All Messages | Collapse All Messages