code review 7479044: cmd/vet: change some warnings to errors for consistency.

cmd/vet: change some warnings to errors for consistency.
Fixes issue 4980.

[r, 2013-03-05 22:08:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-03-05 22:11:14]

LGTM

While you are in there, in main.go these three errorf should be something
like warnf+return instead. Otherwise the first directory with a problem
aborts execution of all other directories in a big scan:

var files []*File
var astFiles []*ast.File
fs := token.NewFileSet()
for _, name := range names {
f, err := os.Open(name)
if err != nil {
*errorf*("%s: %s", name, err)
}
defer f.Close()
data, err := ioutil.ReadAll(f)
if err != nil {
*errorf*("%s: %s", name, err)
}
checkBuildTag(name, data)
parsedFile, err := parser.ParseFile(fs, name, bytes.NewReader(data), 0)
if err != nil {
*errorf*("%s: %s", name, err)
}
files = append(files, &File{fset: fs, name: name, file: parsedFile})
astFiles = append(astFiles, parsedFile)
}

[dsymonds, 2013-03-05 22:13:36]

LGTM

[dsymonds, 2013-03-05 22:18:01]

Also
  Fixes issue XXX.

[r, 2013-03-05 22:31:22]

*** Submitted as https://code.google.com/p/go/source/detail?r=a52c3f39bf7d ***

cmd/vet: change some warnings to errors for consistency.
Fixes issue 4980.

R=golang-dev, rsc, dsymonds
CC=golang-dev
https://codereview.appspot.com/7479044