https://codereview.appspot.com/7479043/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java File google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java (right): https://codereview.appspot.com/7479043/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java#newcode1 google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java:1: /* On 2013/03/07 20:48:49, yanivi wrote: > Please also ...
11 years, 1 month ago
(2013-03-08 17:09:03 UTC)
#3
https://codereview.appspot.com/7479043/diff/1/google-oauth-client-servlet/src...
File
google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java
(right):
https://codereview.appspot.com/7479043/diff/1/google-oauth-client-servlet/src...
google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java:1:
/*
On 2013/03/07 20:48:49, yanivi wrote:
> Please also mark @Experimental some methods in
> com.google.api.client.auth.oauth2.Credential that are @Deprecated
Done.
https://codereview.appspot.com/7479043/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/package-info.java
(right):
https://codereview.appspot.com/7479043/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/package-info.java:21:
* <b>Warning: this package is {@link com.google.api.client.util.Experimental},
and its content may
When adding @Experimental on the pacakge level I get the following error
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile)
on project google-oauth-client: Compilation failure
[ERROR]
/usr/local/google/home/peleyal/code.google.com/google-oauth-java-client/default/google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/package-info.java:[29,0]
error: modifier deprecated not allowed here
As a result I just added the @Experimental in javadoc
Weird.
Issue 7479043: OAuth 63: Mark some parts of the library Experimental
(Closed)
Created 11 years, 1 month ago by peleyal
Modified 11 years, 1 month ago
Reviewers: yanivi
Base URL: https://code.google.com/p/google-oauth-java-client/
Comments: 3