Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 7474049: code review 7474049: hkdf: implemented hash based key derivation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by karalabe
Modified:
5 years, 7 months ago
Reviewers:
agl1
CC:
agl, minux1, agl1, golang-codereviews
Visibility:
Public.

Description

hkdf: implemented hash based key derivation. Detailed description in RFC 5869.

Patch Set 1 #

Patch Set 2 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r 983a4287662a https://code.google.com/p/go.crypto #

Total comments: 6

Patch Set 8 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r ca43617ec9b3 https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 10 : diff -r 61c59dda830a https://code.google.com/p/go.crypto #

Patch Set 11 : diff -r 61c59dda830a https://code.google.com/p/go.crypto #

Patch Set 12 : diff -r 61c59dda830a https://code.google.com/p/go.crypto #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -0 lines) Patch
A hkdf/example_test.go View 1 2 3 4 5 6 7 8 9 1 chunk +60 lines, -0 lines 1 comment Download
A hkdf/hkdf.go View 1 2 3 4 5 6 7 8 9 1 chunk +78 lines, -0 lines 4 comments Download
A hkdf/hkdf_test.go View 1 2 3 4 5 6 7 8 9 1 chunk +370 lines, -0 lines 1 comment Download

Messages

Total messages: 15
karalabe
Hello agl@chromium.org, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 6 months ago (2013-03-07 22:44:58 UTC) #1
karalabe
Added a usage example to make the whole module nicer :)
6 years, 6 months ago (2013-03-08 17:45:48 UTC) #2
agl1
At the high level, we've not exposed a KDF API before and it's unclear whether ...
6 years, 6 months ago (2013-03-12 15:12:15 UTC) #3
karalabe
I think I'll manage the fixes, I'll commit in a few hours, just let me ...
6 years, 6 months ago (2013-03-12 15:38:36 UTC) #4
agl
On Tue, Mar 12, 2013 at 11:38 AM, <peterke@gmail.com> wrote: > Btw, there's one slight ...
6 years, 6 months ago (2013-03-12 15:45:40 UTC) #5
karalabe
Issues should be resolved now, please check it again.
6 years, 6 months ago (2013-03-12 17:10:55 UTC) #6
karalabe
Added some benchmarks in the mean time. Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz: Benchmark16ByteMd5Single 500000 ...
6 years, 5 months ago (2013-04-09 15:35:46 UTC) #7
karalabe
Ok, this kind of got forgotten. Any intentions of including it?
5 years, 9 months ago (2013-12-16 23:47:56 UTC) #8
agl1
https://codereview.appspot.com/7474049/diff/32001/hkdf/hkdf.go File hkdf/hkdf.go (right): https://codereview.appspot.com/7474049/diff/32001/hkdf/hkdf.go#newcode6 hkdf/hkdf.go:6: // Function (HKDF) as defined in Internet Engineering Task ...
5 years, 9 months ago (2013-12-19 21:10:13 UTC) #9
gobot
Replacing golang-dev with golang-codereviews.
5 years, 9 months ago (2013-12-20 16:21:43 UTC) #10
agl1
Any interest in continuing with this?
5 years, 8 months ago (2014-01-14 14:25:32 UTC) #11
karalabe
On 2014/01/14 14:25:32, agl1 wrote: > Any interest in continuing with this? Yes, yes. Sorry ...
5 years, 7 months ago (2014-01-29 09:10:53 UTC) #12
karalabe
Please take another look. I've updated the code as requested. I reorganized your proposal a ...
5 years, 7 months ago (2014-02-10 19:17:13 UTC) #13
agl1
LGTM. I'll make these changes before landing because they're small. Thanks! https://codereview.appspot.com/7474049/diff/76001/hkdf/example_test.go File hkdf/example_test.go (right): ...
5 years, 7 months ago (2014-02-12 19:03:54 UTC) #14
agl1
5 years, 7 months ago (2014-02-12 19:08:38 UTC) #15
*** Submitted as
https://code.google.com/p/go/source/detail?r=dc7486a41a09&repo=crypto ***

go.crypto/hkdf: implement hash-based, key derivation.

Detailed description in RFC 5869.

LGTM=agl
R=agl, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/7474049

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b