code review 7473044: cmd/gc: support channel types in the garbage collector

cmd/gc: support channel types in the garbage collector

[atom, 2013-03-05 09:10:56]

Hello golang-dev@googlegroups.com (cc: rsc, dvyukov),

I'd like you to review this change to
https://code.google.com/p/go/

[dvyukov, 2013-03-08 15:16:35]

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c
File src/pkg/runtime/mgc0.c (right):

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode716
src/pkg/runtime/mgc0.c:716: chan_ret = 0;
s/0/nil/

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode975
src/pkg/runtime/mgc0.c:975: runtime·lock(&lock);
why do you need this lock?

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode1008
src/pkg/runtime/mgc0.c:1008: if(chan_ret == 0) {
s/0/nil/
drop {}

[atom, 2013-03-08 15:25:23]

Hello golang-dev@googlegroups.com, dvyukov@google.com (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[atom, 2013-03-08 15:29:51]

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c
File src/pkg/runtime/mgc0.c (right):

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode716
src/pkg/runtime/mgc0.c:716: chan_ret = 0;
On 2013/03/08 15:16:35, dvyukov wrote:
> s/0/nil/

Done.

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode975
src/pkg/runtime/mgc0.c:975: runtime·lock(&lock);
On 2013/03/08 15:16:35, dvyukov wrote:
> why do you need this lock?

There is no compare&swap in flushptrbuf(). flushptrbuf() uses the same lock.

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode1008
src/pkg/runtime/mgc0.c:1008: if(chan_ret == 0) {
On 2013/03/08 15:16:35, dvyukov wrote:
> s/0/nil/
> drop {}

Done.

[dvyukov, 2013-03-08 15:48:31]

LGTM generally, but I did not follow the GC changes very closely, so better
reviewed by somebody else as well.

[rsc, 2013-03-19 18:38:20]

LGTM

[atom, 2013-03-19 18:51:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=68679922e4fe ***

cmd/gc: support channel types in the garbage collector

R=golang-dev, dvyukov, rsc
CC=golang-dev
https://codereview.appspot.com/7473044