Issue 7470048: code review 7470048: net/http/httputil: remove hop-by-hop headers in ReverseProxy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7470048: code review 7470048: net/http/httputil: remove hop-by-hop headers in ReverseProxy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bradfitz

Modified:
12 years, 9 months ago

Reviewers:
minux1

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http/httputil: remove hop-by-hop headers in ReverseProxy Fixes issue 2735

Patch Set 1 #

Patch Set 2 : diff -r b4a4e1fab659 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b4a4e1fab659 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7c763891c5df https://go.googlecode.com/hg/ #

Total comments: 1

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
	M	src/pkg/net/http/httputil/reverseproxy.go	View	1 2 3	2 chunks	+28 lines, -8 lines	0 comments	Download
	M	src/pkg/net/http/httputil/reverseproxy_test.go	View	1	2 chunks	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2013-03-11 16:49:02 UTC) #1

bradfitz

On Mon, Mar 11, 2013 at 10:07 AM, Russ Cox <rsc@golang.org> wrote: > LGTM > ...

12 years, 9 months ago (2013-03-11 17:12:20 UTC) #3

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=9df7217ec408 *** net/http/httputil: remove hop-by-hop headers in ReverseProxy Fixes issue 2735 R=golang-dev, ...

12 years, 9 months ago (2013-03-11 17:32:34 UTC) #4

minux1

12 years, 9 months ago (2013-03-11 18:29:16 UTC) #5

Message was sent while issue was closed.

https://codereview.appspot.com/7470048/diff/10001/src/pkg/net/http/httputil/r...
File src/pkg/net/http/httputil/reverseproxy_test.go (right):

https://codereview.appspot.com/7470048/diff/10001/src/pkg/net/http/httputil/r...
src/pkg/net/http/httputil/reverseproxy_test.go:33: t.Errorf("handler got
Keep-Alive header value %q", c)
really, is it Upgrade or Keep-Alive?

Expand All Messages | Collapse All Messages