Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 7463043: code review 7463043: go.exp: add packages ebnf, gotype, inotify, locale, ssa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

go.exp: add packages ebnf, gotype, inotify, locale, ssa, utf8string, winfsnotify. Packages moved from main repo, with minor adjustments so tests pass. See also https://codereview.appspot.com/7456047

Patch Set 1 #

Patch Set 2 : diff -r c7d5f75d7150 https://code.google.com/p/go.exp #

Patch Set 3 : diff -r c7d5f75d7150 https://code.google.com/p/go.exp #

Patch Set 4 : diff -r c7d5f75d7150 https://code.google.com/p/go.exp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24185 lines, -0 lines) Patch
A ebnf/ebnf.go View 1 2 3 1 chunk +269 lines, -0 lines 0 comments Download
A ebnf/ebnf_test.go View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
A ebnf/parser.go View 1 2 3 1 chunk +190 lines, -0 lines 0 comments Download
A ebnflint/doc.go View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A ebnflint/ebnflint.go View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A ebnflint/ebnflint_test.go View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A gotype/doc.go View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A gotype/gotype.go View 1 2 3 1 chunk +205 lines, -0 lines 0 comments Download
A gotype/gotype_test.go View 1 2 3 1 chunk +215 lines, -0 lines 0 comments Download
A gotype/testdata/test1.go View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A inotify/inotify_linux.go View 1 2 3 1 chunk +300 lines, -0 lines 0 comments Download
A inotify/inotify_linux_test.go View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A locale/collate/Makefile View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A locale/collate/build/builder.go View 1 2 3 1 chunk +691 lines, -0 lines 0 comments Download
A locale/collate/build/builder_test.go View 1 2 3 1 chunk +290 lines, -0 lines 0 comments Download
A locale/collate/build/colelem.go View 1 2 3 1 chunk +294 lines, -0 lines 0 comments Download
A locale/collate/build/colelem_test.go View 1 2 3 1 chunk +215 lines, -0 lines 0 comments Download
A locale/collate/build/contract.go View 1 2 3 1 chunk +307 lines, -0 lines 0 comments Download
A locale/collate/build/contract_test.go View 1 2 3 1 chunk +264 lines, -0 lines 0 comments Download
A locale/collate/build/order.go View 1 2 3 1 chunk +393 lines, -0 lines 0 comments Download
A locale/collate/build/order_test.go View 1 2 3 1 chunk +229 lines, -0 lines 0 comments Download
A locale/collate/build/table.go View 1 2 3 1 chunk +120 lines, -0 lines 0 comments Download
A locale/collate/build/trie.go View 1 2 3 1 chunk +290 lines, -0 lines 0 comments Download
A locale/collate/build/trie_test.go View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A locale/collate/collate.go View 1 2 3 1 chunk +589 lines, -0 lines 0 comments Download
A locale/collate/collate_test.go View 1 2 3 1 chunk +516 lines, -0 lines 0 comments Download
A locale/collate/colltab/colelem.go View 1 2 3 1 chunk +369 lines, -0 lines 0 comments Download
A locale/collate/colltab/colelem_test.go View 1 2 3 1 chunk +162 lines, -0 lines 0 comments Download
A locale/collate/colltab/colltab.go View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A locale/collate/colltab/contract.go View 1 2 3 1 chunk +145 lines, -0 lines 0 comments Download
A locale/collate/colltab/contract_test.go View 1 2 3 1 chunk +132 lines, -0 lines 0 comments Download
A locale/collate/colltab/export.go View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A locale/collate/colltab/table.go View 1 2 3 1 chunk +274 lines, -0 lines 0 comments Download
A locale/collate/colltab/trie.go View 1 2 3 1 chunk +160 lines, -0 lines 0 comments Download
A locale/collate/colltab/trie_test.go View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
A locale/collate/export_test.go View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A locale/collate/index.go View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A locale/collate/maketables.go View 1 2 3 1 chunk +719 lines, -0 lines 0 comments Download
A locale/collate/regtest.go View 1 2 3 1 chunk +269 lines, -0 lines 0 comments Download
A locale/collate/sort.go View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A locale/collate/sort_test.go View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A locale/collate/table_test.go View 1 2 3 1 chunk +291 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/Makefile View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/chars.go View 1 2 3 1 chunk +937 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/col.go View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/colcmp.go View 1 2 3 1 chunk +528 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/darwin.go View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/gen.go View 1 2 3 1 chunk +179 lines, -0 lines 0 comments Download
A locale/collate/tools/colcmp/icu.go View 1 2 3 1 chunk +209 lines, -0 lines 0 comments Download
A ssa/blockopt.go View 1 2 3 1 chunk +173 lines, -0 lines 0 comments Download
A ssa/builder.go View 1 2 3 1 chunk +2821 lines, -0 lines 0 comments Download
A ssa/doc.go View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A ssa/dom.go View 1 2 3 1 chunk +296 lines, -0 lines 0 comments Download
A ssa/emit.go View 1 2 3 1 chunk +254 lines, -0 lines 0 comments Download
A ssa/func.go View 1 2 3 1 chunk +591 lines, -0 lines 0 comments Download
A ssa/importer.go View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A ssa/interp/external.go View 1 2 3 1 chunk +344 lines, -0 lines 0 comments Download
A ssa/interp/external_plan9.go View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A ssa/interp/external_unix.go View 1 2 3 1 chunk +137 lines, -0 lines 0 comments Download
A ssa/interp/external_windows.go View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A ssa/interp/interp.go View 1 2 3 1 chunk +623 lines, -0 lines 0 comments Download
A ssa/interp/interp_test.go View 1 2 3 1 chunk +231 lines, -0 lines 0 comments Download
A ssa/interp/map.go View 1 2 3 1 chunk +101 lines, -0 lines 0 comments Download
A ssa/interp/ops.go View 1 2 3 1 chunk +1371 lines, -0 lines 0 comments Download
A ssa/interp/reflect.go View 1 2 3 1 chunk +441 lines, -0 lines 0 comments Download
A ssa/interp/testdata/coverage.go View 1 2 3 1 chunk +447 lines, -0 lines 0 comments Download
A ssa/interp/value.go View 1 2 3 1 chunk +466 lines, -0 lines 0 comments Download
A ssa/lift.go View 1 2 3 1 chunk +512 lines, -0 lines 0 comments Download
A ssa/literal.go View 1 2 3 1 chunk +177 lines, -0 lines 0 comments Download
A ssa/lvalue.go View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
A ssa/print.go View 1 2 3 1 chunk +398 lines, -0 lines 0 comments Download
A ssa/promote.go View 1 2 3 1 chunk +446 lines, -0 lines 0 comments Download
A ssa/sanity.go View 1 2 3 1 chunk +306 lines, -0 lines 0 comments Download
A ssa/ssa.go View 1 2 3 1 chunk +1309 lines, -0 lines 0 comments Download
A ssa/ssadump.go View 1 2 3 1 chunk +156 lines, -0 lines 0 comments Download
A ssa/util.go View 1 2 3 1 chunk +227 lines, -0 lines 0 comments Download
A utf8string/string.go View 1 2 3 1 chunk +203 lines, -0 lines 0 comments Download
A utf8string/string_test.go View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A winfsnotify/winfsnotify.go View 1 2 3 1 chunk +580 lines, -0 lines 0 comments Download
A winfsnotify/winfsnotify_test.go View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.exp
12 years, 3 months ago (2013-03-02 18:48:35 UTC) #1
minux1
LGTM.
12 years, 3 months ago (2013-03-02 18:53:01 UTC) #2
r
12 years, 3 months ago (2013-03-02 19:10:45 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=b15e3af3a6a0&repo=exp ***

go.exp: add packages ebnf, gotype, inotify, locale, ssa, utf8string,
winfsnotify.
Packages moved from main repo, with minor adjustments so tests pass.

See also https://codereview.appspot.com/7456047

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7463043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b