code review 7461046: all: fix typos

all: fix typos

[bradfitz, 2013-06-04 22:39:23]

ping.

[khr, 2013-06-05 01:59:54]

LGTM

[minux1, 2013-06-07 09:32:43]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, khr@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-06-07 09:54:59]

LGTM

I think khr already LGTMed an earlier version of this CL too.
 On Jun 7, 2013 11:32 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1, bradfitz, khr,
>
> Message:
> Hello golang-dev@googlegroups.com, bradfitz@golang.org, khr@golang.org
> (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> all: fix typos
>
> Please review this at
https://codereview.appspot.**com/7461046/<https://codereview.appspot.com/7461...
>
> Affected files:
>   M src/cmd/5c/peep.c
>   M src/cmd/5g/gsubr.c
>   M src/cmd/5g/peep.c
>   M src/cmd/5g/reg.c
>   M src/cmd/5l/pass.c
>   M src/cmd/6c/peep.c
>   M src/cmd/6c/txt.c
>   M src/cmd/6g/cgen.c
>   M src/cmd/6g/gsubr.c
>   M src/cmd/6g/peep.c
>   M src/cmd/8c/peep.c
>   M src/cmd/8c/txt.c
>   M src/cmd/8g/cgen.c
>   M src/cmd/8g/peep.c
>   M src/cmd/8g/reg.c
>   M src/cmd/cc/funct.c
>   M src/cmd/cc/lexbody
>   M src/cmd/cc/pgen.c
>   M src/cmd/cc/pswt.c
>   M src/cmd/dist/plan9.c
>   M src/cmd/dist/unix.c
>   M src/cmd/gc/obj.c
>   M src/cmd/gc/swt.c
>   M src/cmd/go/test.bash
>   M src/cmd/ld/data.c
>   M src/cmd/ld/dwarf.c
>   M src/cmd/yacc/units.txt
>   M src/libmach/6obj.c
>   M src/libmach/8obj.c
>   M test/chan/doubleselect.go
>
>
> Index: src/cmd/5c/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/5c/peep.c
> +++ b/src/cmd/5c/peep.c
> @@ -462,7 +462,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %Drar; return 0\n", v2);
>                         return 0;
> Index: src/cmd/5g/gsubr.c
> ==============================**==============================**=======
> --- a/src/cmd/5g/gsubr.c
> +++ b/src/cmd/5g/gsubr.c
> @@ -1905,7 +1905,7 @@
>
>         for(i=1; i<o; i++) {
>                 if(oary[i] >= 0)
> -                       fatal("cant happen");
> +                       fatal("can't happen");
>                 gins(AMOVW, &n1, reg);
>                 n1.xoffset = -(oary[i]+1);
>         }
> Index: src/cmd/5g/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/5g/peep.c
> +++ b/src/cmd/5g/peep.c
> @@ -496,7 +496,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %Drar; return 0\n", v2);
>                         return 0;
> @@ -973,7 +973,7 @@
>         switch(p->as) {
>
>         default:
> -               print("copyu: cant find %A\n", p->as);
> +               print("copyu: can't find %A\n", p->as);
>                 return 2;
>
>         case AMOVM:
> @@ -1288,7 +1288,7 @@
>                                 return 1;
>                         return 0;
>                 }
> -               print("copyau1: cant tell %P\n", p);
> +               print("copyau1: can't tell %P\n", p);
>         }
>         return 0;
>  }
> Index: src/cmd/5g/reg.c
> ==============================**==============================**=======
> --- a/src/cmd/5g/reg.c
> +++ b/src/cmd/5g/reg.c
> @@ -816,7 +816,7 @@
>                 a->type = D_CONST;
>
>         if(v->addr)
> -               fatal("addmove: shouldnt be doing this %A\n", a);
> +               fatal("addmove: shouldn't be doing this %A\n", a);
>
>         switch(v->etype) {
>         default:
> Index: src/cmd/5l/pass.c
> ==============================**==============================**=======
> --- a/src/cmd/5l/pass.c
> +++ b/src/cmd/5l/pass.c
> @@ -130,7 +130,7 @@
>                                 r = prg();
>                                 *r = *p;
>                                 if(!(r->mark&FOLL))
> -                                       print("cant happen 1\n");
> +                                       print("can't happen 1\n");
>                                 r->mark |= FOLL;
>                                 if(p != q) {
>                                         p = p->link;
> @@ -150,7 +150,7 @@
>                                 if(!(r->link->mark&FOLL))
>                                         xfol(r->link, last);
>                                 if(!(r->cond->mark&FOLL))
> -                                       print("cant happen 2\n");
> +                                       print("can't happen 2\n");
>                                 return;
>                         }
>                 }
> Index: src/cmd/6c/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/6c/peep.c
> +++ b/src/cmd/6c/peep.c
> @@ -483,7 +483,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %D rar; return 0\n", v2);
>                         return 0;
> Index: src/cmd/6c/txt.c
> ==============================**==============================**=======
> --- a/src/cmd/6c/txt.c
> +++ b/src/cmd/6c/txt.c
> @@ -1188,7 +1188,7 @@
>         else if(n->left->op == OREGISTER)
>                 idx.ptr = n->left->reg;
>         else if(n->left->op != OADDR) {
> -               reg[D_BP]++;    // cant be used as a base
> +               reg[D_BP]++;    // can't be used as a base
>                 regalloc(&nod1, &qregnode, Z);
>                 cgen(n->left, &nod1);
>                 idx.ptr = nod1.reg;
> Index: src/cmd/6g/cgen.c
> ==============================**==============================**=======
> --- a/src/cmd/6g/cgen.c
> +++ b/src/cmd/6g/cgen.c
> @@ -1480,7 +1480,7 @@
>   * Small structs or arrays with elements of basic type are
>   * also supported.
>   * nr is N when assigning a zero value.
> - * return 1 if can do, 0 if cant.
> + * return 1 if can do, 0 if can't.
>   */
>  int
>  componentgen(Node *nr, Node *nl)
> Index: src/cmd/6g/gsubr.c
> ==============================**==============================**=======
> --- a/src/cmd/6g/gsubr.c
> +++ b/src/cmd/6g/gsubr.c
> @@ -494,7 +494,7 @@
>                 break;
>
>         case 2:         // offset output arg
> -fatal("shouldnt be used");
> +fatal("shouldn't be used");
>                 n->op = OINDREG;
>                 n->val.u.reg = D_SP;
>                 n->xoffset += types[tptr]->width;
> @@ -2038,7 +2038,7 @@
>
>         for(i=1; i<o; i++) {
>                 if(oary[i] >= 0)
> -                       fatal("cant happen");
> +                       fatal("can't happen");
>                 gins(AMOVQ, &n1, reg);
>                 n1.xoffset = -(oary[i]+1);
>         }
> Index: src/cmd/6g/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/6g/peep.c
> +++ b/src/cmd/6g/peep.c
> @@ -843,7 +843,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %D rar; return 0\n", v2);
>                         return 0;
> Index: src/cmd/8c/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/8c/peep.c
> +++ b/src/cmd/8c/peep.c
> @@ -403,7 +403,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %D rar; return 0\n", v2);
>                         return 0;
> Index: src/cmd/8c/txt.c
> ==============================**==============================**=======
> --- a/src/cmd/8c/txt.c
> +++ b/src/cmd/8c/txt.c
> @@ -963,7 +963,7 @@
>         else if(n->left->op == OREGISTER)
>                 idx.ptr = n->left->reg;
>         else if(n->left->op != OADDR) {
> -               reg[D_BP]++;    // cant be used as a base
> +               reg[D_BP]++;    // can't be used as a base
>                 regalloc(&nod1, &regnode, Z);
>                 cgen(n->left, &nod1);
>                 idx.ptr = nod1.reg;
> Index: src/cmd/8g/cgen.c
> ==============================**==============================**=======
> --- a/src/cmd/8g/cgen.c
> +++ b/src/cmd/8g/cgen.c
> @@ -1319,7 +1319,7 @@
>   * copy a composite value by moving its individual components.
>   * Slices, strings and interfaces are supported.
>   * nr is N when assigning a zero value.
> - * return 1 if can do, 0 if cant.
> + * return 1 if can do, 0 if can't.
>   */
>  int
>  componentgen(Node *nr, Node *nl)
> Index: src/cmd/8g/peep.c
> ==============================**==============================**=======
> --- a/src/cmd/8g/peep.c
> +++ b/src/cmd/8g/peep.c
> @@ -608,7 +608,7 @@
>                 }
>                 t = copyu(p, v2, A);
>                 switch(t) {
> -               case 2: /* rar, cant split */
> +               case 2: /* rar, can't split */
>                         if(debug['P'])
>                                 print("; %D rar; return 0\n", v2);
>                         return 0;
> Index: src/cmd/8g/reg.c
> ==============================**==============================**=======
> --- a/src/cmd/8g/reg.c
> +++ b/src/cmd/8g/reg.c
> @@ -1824,7 +1824,7 @@
>  static void
>  fixtemp(Prog *firstp)
>  {
> -       static uint8 counts[1<<16]; // A hash table to count variable
> occurences.
> +       static uint8 counts[1<<16]; // A hash table to count variable
> occurrences.
>         int i;
>         Prog *p, *p2;
>         uint32 h;
> Index: src/cmd/cc/funct.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/funct.c
> +++ b/src/cmd/cc/funct.c
> @@ -235,7 +235,7 @@
>         return 0;
>
>  bad:
> -       diag(n, "cant rewrite typestr for op %O\n", o);
> +       diag(n, "can't rewrite typestr for op %O\n", o);
>         prtree(n, "isfunct");
>         n->type = T;
>         return 1;
> Index: src/cmd/cc/lexbody
> ==============================**==============================**=======
> --- a/src/cmd/cc/lexbody
> +++ b/src/cmd/cc/lexbody
> @@ -762,7 +762,7 @@
>                 return;
>         }
>         fr = frexp(native, &exp);
> -       f = 2097152L;           /* shouldnt use fp constants here */
> +       f = 2097152L;           /* shouldn't use fp constants here */
>         fr = modf(fr*f, &ho);
>         ieee->h = ho;
>         ieee->h &= 0xfffffL;
> Index: src/cmd/cc/pgen.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/pgen.c
> +++ b/src/cmd/cc/pgen.c
> @@ -75,7 +75,7 @@
>          */
>         for(n1 = nn;; n1 = n1->left) {
>                 if(n1 == Z) {
> -                       diag(nn, "cant find function name");
> +                       diag(nn, "can't find function name");
>                         return;
>                 }
>                 if(n1->op == ONAME)
> Index: src/cmd/cc/pswt.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/pswt.c
> +++ b/src/cmd/cc/pswt.c
> @@ -156,7 +156,7 @@
>                 return;
>         }
>         fr = frexp(native, &exp);
> -       f = 2097152L;           /* shouldnt use fp constants here */
> +       f = 2097152L;           /* shouldn't use fp constants here */
>         fr = modf(fr*f, &ho);
>         ieee->h = ho;
>         ieee->h &= 0xfffffL;
> Index: src/cmd/dist/plan9.c
> ==============================**==============================**=======
> --- a/src/cmd/dist/plan9.c
> +++ b/src/cmd/dist/plan9.c
> @@ -578,7 +578,7 @@
>         return np >= ns && strcmp(p+np-ns, suffix) == 0;
>  }
>
> -// hasprefix reports whether p begins wtih prefix.
> +// hasprefix reports whether p begins with prefix.
>  bool
>  hasprefix(char *p, char *prefix)
>  {
> Index: src/cmd/dist/unix.c
> ==============================**==============================**=======
> --- a/src/cmd/dist/unix.c
> +++ b/src/cmd/dist/unix.c
> @@ -548,7 +548,7 @@
>         return np >= ns && strcmp(p+np-ns, suffix) == 0;
>  }
>
> -// hasprefix reports whether p begins wtih prefix.
> +// hasprefix reports whether p begins with prefix.
>  bool
>  hasprefix(char *p, char *prefix)
>  {
> Index: src/cmd/gc/obj.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/obj.c
> +++ b/src/cmd/gc/obj.c
> @@ -235,7 +235,7 @@
>                 return;
>         }
>         fr = frexp(native, &exp);
> -       f = 2097152L;           /* shouldnt use fp constants here */
> +       f = 2097152L;           /* shouldn't use fp constants here */
>         fr = modf(fr*f, &ho);
>         h = ho;
>         h &= 0xfffffL;
> Index: src/cmd/gc/swt.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/swt.c
> +++ b/src/cmd/gc/swt.c
> @@ -315,7 +315,7 @@
>                 }
>                 stat = concat(stat, n->nbody);
>
> -               // botch - shouldnt fall thru declaration
> +               // botch - shouldn't fall thru declaration
>                 last = stat->end->n;
>                 if(last->op == OXFALL) {
>                         if(typeswvar) {
> Index: src/cmd/go/test.bash
> ==============================**==============================**=======
> --- a/src/cmd/go/test.bash
> +++ b/src/cmd/go/test.bash
> @@ -151,7 +151,7 @@
>  fi
>  rm -f test_std.list
>
> -# issue 4096. Validate the output of unsucessful go install foo/quxx
> +# issue 4096. Validate the output of unsuccessful go install foo/quxx
>  if [ $(./testgo install 'foo/quxx' 2>&1 | grep -c 'cannot find package
> "foo/quxx" in any of') -ne 1 ] ; then
>         echo 'go install foo/quxx expected error: .*cannot find package
> "foo/quxx" in any of'
>         ok=false
> Index: src/cmd/ld/data.c
> ==============================**==============================**=======
> --- a/src/cmd/ld/data.c
> +++ b/src/cmd/ld/data.c
> @@ -367,7 +367,7 @@
>  {
>         Sym *s;
>
> -       // -d supresses dynamic loader format, so we may as well not
> +       // -d suppresses dynamic loader format, so we may as well not
>         // compute these sections or mark their symbols as reachable.
>         if(debug['d'] && HEADTYPE != Hwindows)
>                 return;
> Index: src/cmd/ld/dwarf.c
> ==============================**==============================**=======
> --- a/src/cmd/ld/dwarf.c
> +++ b/src/cmd/ld/dwarf.c
> @@ -133,7 +133,7 @@
>  /*
>   * Defining Abbrevs.  This is hardcoded, and there will be
>   * only a handful of them.  The DWARF spec places no restriction on
> - * the ordering of atributes in the Abbrevs and DIEs, and we will
> + * the ordering of attributes in the Abbrevs and DIEs, and we will
>   * always write them out in the order of declaration in the abbrev.
>   * This implementation relies on tag, attr < 127, so they serialize as
>   * a char.  Higher numbered user-defined tags or attributes can be used
> @@ -1646,7 +1646,7 @@
>  }
>
>  /*
> - * Generate short opcodes when possible, long ones when neccesary.
> + * Generate short opcodes when possible, long ones when necessary.
>   * See section 6.2.5
>   */
>
> @@ -1938,7 +1938,7 @@
>  {
>         CIERESERVE = 16,
>         DATAALIGNMENTFACTOR = -4,       // TODO -PtrSize?
> -       FAKERETURNCOLUMN = 16           // TODO gdb6 doesnt like > 15?
> +       FAKERETURNCOLUMN = 16           // TODO gdb6 doesn't like > 15?
>  };
>
>  static void
> Index: src/cmd/yacc/units.txt
> ==============================**==============================**=======
> --- a/src/cmd/yacc/units.txt
> +++ b/src/cmd/yacc/units.txt
> @@ -481,7 +481,7 @@
>  mh                     millihenry
>  mhz                    1e+6/sec
>  mil                    1e-3 in
> -millenium              1000 year
> +millennium             1000 year
>  minersinch             1.5 ft³/min
>  minim                  1|60 fldr
>  mo                     month
> Index: src/libmach/6obj.c
> ==============================**==============================**=======
> --- a/src/libmach/6obj.c
> +++ b/src/libmach/6obj.c
> @@ -52,7 +52,7 @@
>  {
>         uchar *s = (uchar*)t;
>
> -       return  s[0] == (ANAME&0xff)                    /* aslo = ANAME */
> +       return  s[0] == (ANAME&0xff)                    /* also = ANAME */
>                 && s[1] == ((ANAME>>8)&0xff)
>                 && s[2] == D_FILE                       /* type */
>                 && s[3] == 1                            /* sym */
> Index: src/libmach/8obj.c
> ==============================**==============================**=======
> --- a/src/libmach/8obj.c
> +++ b/src/libmach/8obj.c
> @@ -52,7 +52,7 @@
>  {
>         uchar *s = (uchar*)t;
>
> -       return  s[0] == (ANAME&0xff)                    /* aslo = ANAME */
> +       return  s[0] == (ANAME&0xff)                    /* also = ANAME */
>                 && s[1] == ((ANAME>>8)&0xff)
>                 && s[2] == D_FILE                       /* type */
>                 && s[3] == 1                            /* sym */
> Index: test/chan/doubleselect.go
> ==============================**==============================**=======
> --- a/test/chan/doubleselect.go
> +++ b/test/chan/doubleselect.go
> @@ -36,7 +36,7 @@
>  }
>
>  // mux receives the values from sender and forwards them onto another
> channel.
> -// It would be simplier to just have sender's four cases all be the same
> +// It would be simpler to just have sender's four cases all be the same
>  // channel, but this doesn't actually trigger the bug.
>  func mux(out chan<- int, in <-chan int, done chan<- bool) {
>         for v := range in {
>
>
>

[r, 2013-06-07 15:19:27]

LGTM but i must say ill miss kens lack of apostrophes

[minux1, 2013-06-09 13:50:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=b2d048b10cfc ***

all: fix typos

R=golang-dev, bradfitz, khr, r
CC=golang-dev
https://codereview.appspot.com/7461046