code review 7453048: misc/dashboard/builder: make -fail mode faster

misc/dashboard/builder: make -fail mode faster

Don't check out the repository if we're just going to fail everything.

[rsc, 2013-03-04 15:02:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-03-04 15:10:53]

LGTM

On Mon, Mar 4, 2013 at 7:02 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> misc/dashboard/builder: make -fail mode faster
>
> Don't check out the repository if we're just going to fail everything.
>
> Please review this at
https://codereview.appspot.**com/7453048/<https://codereview.appspot.com/7453...
>
> Affected files:
>   M misc/dashboard/builder/main.go
>
>
> Index: misc/dashboard/builder/main.go
> ==============================**==============================**=======
> --- a/misc/dashboard/builder/main.**go
> +++ b/misc/dashboard/builder/main.**go
> @@ -83,7 +83,7 @@
>         }
>
>         // set up work environment, use existing enviroment if possible
> -       if goroot.Exists() {
> +       if goroot.Exists() || *failAll {
>                 log.Print("Found old workspace, will use it")
>         } else {
>                 if err := os.RemoveAll(*buildroot); err != nil {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-03-04 15:31:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=41f1421cecd1 ***

misc/dashboard/builder: make -fail mode faster

Don't check out the repository if we're just going to fail everything.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7453048