Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 7452043: Fixed layout issues as per design

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by jeff.pihach
Modified:
7 years, 8 months ago
Reviewers:
mp+151081, goodspud, matthew.scott, gary.poster
Visibility:
Public.

Description

Fixed layout issues as per design https://code.launchpad.net/~hatch/juju-gui/1125424-loading-visuals/+merge/151081 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed layout issues as per design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/login.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/stylesheet.less View 1 3 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
7 years, 8 months ago (2013-02-28 19:29:43 UTC) #1
goodspud
LGTM. Sign off from Design
7 years, 8 months ago (2013-02-28 19:38:48 UTC) #2
gary.poster
LGTM. Thank you! Gary
7 years, 8 months ago (2013-02-28 20:33:52 UTC) #3
matthew.scott
LGTM - a super-minor and a note. https://codereview.appspot.com/7452043/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/7452043/diff/1/lib/views/stylesheet.less#newcode1607 lib/views/stylesheet.less:1607: font-family: Ubuntu ...
7 years, 8 months ago (2013-02-28 23:12:43 UTC) #4
jeff.pihach
Thanks for the reviews! Reply's below. https://codereview.appspot.com/7452043/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/7452043/diff/1/lib/views/stylesheet.less#newcode1607 lib/views/stylesheet.less:1607: font-family: Ubuntu Medium, ...
7 years, 8 months ago (2013-02-28 23:20:28 UTC) #5
jeff.pihach
7 years, 8 months ago (2013-02-28 23:26:56 UTC) #6
*** Submitted:

Fixed layout issues as per design

R=goodspud, gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7452043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b