Issue 74510043: code review 74510043: runtime: fix missing nacl/386 symbol

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 74510043: code review 74510043: runtime: fix missing nacl/386 symbol (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dave

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
minux1, rsc, golang-codereviews

Visibility:
Public.

Description

runtime: fix missing nacl/386 symbol syscall.naclWrite was missing from sys_nacl_386.s This gets ./make.bash passing, but doesn't pass validation. I'm not sure if this is the fault of this change, or validation was broken anyway.

Patch Set 1 #

Patch Set 2 : diff -r 4d38723d03f0 https://code.google.com/p/go #

Patch Set 3 : diff -r 4d38723d03f0 https://code.google.com/p/go #

Patch Set 4 : diff -r 4d38723d03f0 https://code.google.com/p/go #

Patch Set 5 : diff -r 1e21c0781262 https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/pkg/runtime/sys_nacl_386.s	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-12 09:17:06 UTC) #1

dave_cheney.net

11 years, 3 months ago (2014-03-12 20:58:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ba6c3dd5f2cc ***

runtime: fix missing nacl/386 symbol

syscall.naclWrite was missing from sys_nacl_386.s

This gets ./make.bash passing, but doesn't pass validation. I'm not sure if this
is the fault of this change, or validation was broken anyway.

LGTM=rsc
R=minux.ma, rsc
CC=golang-codereviews
https://codereview.appspot.com/74510043

Expand All Messages | Collapse All Messages