Issue 7450050: code review 7450050: old/netchan: delete as part of move to go.exp/old/netchan

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7450050: code review 7450050: old/netchan: delete as part of move to go.exp/old/netchan (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by r

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

old/netchan: delete as part of move to go.exp/old/netchan

Patch Set 1 #

Patch Set 2 : diff -r 4c879096e24a https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -1472 lines)			Patch
R	src/pkg/old/netchan/common.go	View	1 chunk	+0 lines, -338 lines	0 comments	Download
R	src/pkg/old/netchan/export.go	View	1 chunk	+0 lines, -400 lines	0 comments	Download
R	src/pkg/old/netchan/import.go	View	1 chunk	+0 lines, -287 lines	0 comments	Download
R	src/pkg/old/netchan/netchan_test.go	View	1 chunk	+0 lines, -447 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-03-02 19:30:12 UTC) #1

minux1

LGTM. Please update doc/go1.1.html (in a follow-up CL). cmd/dist/build.c has an array called unreleased, perhaps ...

12 years, 3 months ago (2013-03-02 19:38:21 UTC) #2

12 years, 3 months ago (2013-03-02 19:45:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=119b4c35a4fe ***

old/netchan: delete as part of move to go.exp/old/netchan

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7450050

Expand All Messages | Collapse All Messages