Issue 7450049: code review 7450049: cmd/cgo: don't reimplement os/exec in util.go.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7450049: code review 7450049: cmd/cgo: don't reimplement os/exec in util.go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by remyoudompheng

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/cgo: don't reimplement os/exec in util.go.

Patch Set 2 : diff -r 38b1893be35d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 38b1893be35d https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -43 lines)			Patch
	M	src/cmd/cgo/util.go	View	1	2 chunks	+10 lines, -43 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2013-03-01 18:48:22 UTC) #1

rsc

I think there was a reason I did this. I don't remember what it was.

12 years, 3 months ago (2013-03-01 20:03:42 UTC) #2

rsc

LGTM Oh, this is cmd/cgo, not cmd/go. Then it's just that it predated os/exec.

12 years, 3 months ago (2013-03-01 20:04:04 UTC) #3

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=25ade06c3c16 *** cmd/cgo: don't reimplement os/exec in util.go. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/7450049 ...

12 years, 3 months ago (2013-03-01 20:04:17 UTC) #4

Submitting to kick off a new row on the dashboard.

Expand All Messages | Collapse All Messages