Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(969)

Issue 7446047: code review 7446047: runtime: declare addtimer/deltimer in runtime.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dvyukov
Modified:
12 years ago
Reviewers:
CC:
golang-dev, remyoudompheng, rsc
Visibility:
Public.

Description

runtime: declare addtimer/deltimer in runtime.h In preparation for integrated network poller (https://codereview.appspot.com/7326051), this is required to handle deadlines.

Patch Set 1 #

Patch Set 2 : diff -r b31de657acdb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b31de657acdb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9742f722b558 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M src/pkg/runtime/runtime.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/time.goc View 1 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years ago (2013-03-02 08:21:38 UTC) #1
remyoudompheng
On 2013/3/2 <dvyukov@google.com> wrote: > Reviewers: golang-dev1, > > Message: > Hello golang-dev@googlegroups.com, > > ...
12 years ago (2013-03-02 08:58:49 UTC) #2
dvyukov
On 2013/03/02 08:58:49, remyoudompheng wrote: > On 2013/3/2 <mailto:dvyukov@google.com> wrote: > > Reviewers: golang-dev1, > ...
12 years ago (2013-03-02 10:14:43 UTC) #3
rsc
LGTM
12 years ago (2013-03-04 15:06:51 UTC) #4
dvyukov
12 years ago (2013-03-05 07:39:45 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=2344e072a1f6 ***

runtime: declare addtimer/deltimer in runtime.h
In preparation for integrated network poller
(https://codereview.appspot.com/7326051),
this is required to handle deadlines.

R=golang-dev, remyoudompheng, rsc
CC=golang-dev
https://codereview.appspot.com/7446047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b