Issue 7445050: code review 7445050: doc/go1.1.html: document the moving of exp/... and old/....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7445050: code review 7445050: doc/go1.1.html: document the moving of exp/... and old/.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:
volker.dobler

CC:
golang-dev, minux1

Visibility:
Public.

Description

doc/go1.1.html: document the moving of exp/... and old/....

Patch Set 2 : diff -r 119b4c35a4fe https://code.google.com/p/go/ #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	doc/go1.1.html	View	1	1 chunk	+23 lines, -1 line	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-02 19:46:03 UTC) #1

minux1

LGTM https://codereview.appspot.com/7445050/diff/1/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/7445050/diff/1/doc/go1.1.html#newcode185 doc/go1.1.html:185: <h3 id="exp_old">Exp and old subtrees moved to go.net ...

12 years ago (2013-03-02 19:54:36 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=e48fcf33f1bb *** doc/go1.1.html: document the moving of exp/... and old/.... R=golang-dev, minux.ma ...

12 years ago (2013-03-02 19:55:28 UTC) #3

volker.dobler

NOT LGTM https://codereview.appspot.com/7445050/diff/2002/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/7445050/diff/2002/doc/go1.1.html#newcode196 doc/go1.1.html:196: $ go get code.google.com/go.exp/ssa Shouldn't it be ...

12 years ago (2013-03-03 09:07:06 UTC) #4

sigh.

-rob

Expand All Messages | Collapse All Messages