Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1041)

Issue 7444052: Add a CharmInfo API command.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by frankban
Modified:
7 years, 5 months ago
Reviewers:
dimitern, mp+151295, rog
Visibility:
Public.

Description

Add a CharmInfo API command. Add a CharmInfo API command to get information about a charm, given its URL. It is needed by the Juju GUI, modeled upon the similar one in pyJuju. https://code.launchpad.net/~frankban/juju-core/bug-1130154-api-charm-info/+merge/151295 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add a CharmInfo API command. #

Total comments: 4

Patch Set 3 : Add a CharmInfo API command. #

Total comments: 1

Patch Set 4 : Add a CharmInfo API command. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/apiclient.go View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M state/apiserver/api_test.go View 1 2 3 chunks +59 lines, -0 lines 0 comments Download
M state/apiserver/apiserver.go View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8
frankban
Please take a look.
7 years, 5 months ago (2013-03-01 17:38:11 UTC) #1
dimitern
LGTM with a couple of trivial suggestions. https://codereview.appspot.com/7444052/diff/1/state/api/api_test.go File state/api/api_test.go (right): https://codereview.appspot.com/7444052/diff/1/state/api/api_test.go#newcode199 state/api/api_test.go:199: c.Assert(info.Name, Equals, ...
7 years, 5 months ago (2013-03-05 19:41:20 UTC) #2
frankban
Please take a look. https://codereview.appspot.com/7444052/diff/1/state/api/api_test.go File state/api/api_test.go (right): https://codereview.appspot.com/7444052/diff/1/state/api/api_test.go#newcode199 state/api/api_test.go:199: c.Assert(info.Name, Equals, "wordpress") On 2013/03/05 ...
7 years, 5 months ago (2013-03-05 20:03:23 UTC) #3
rog
LGTM with the below fixed. https://codereview.appspot.com/7444052/diff/5001/state/api/api_test.go File state/api/api_test.go (right): https://codereview.appspot.com/7444052/diff/5001/state/api/api_test.go#newcode543 state/api/api_test.go:543: c.Assert(err, ErrorMatches, t.err) i'd ...
7 years, 5 months ago (2013-03-06 19:33:12 UTC) #4
frankban
Please take a look. https://codereview.appspot.com/7444052/diff/5001/state/api/api_test.go File state/api/api_test.go (right): https://codereview.appspot.com/7444052/diff/5001/state/api/api_test.go#newcode543 state/api/api_test.go:543: c.Assert(err, ErrorMatches, t.err) On 2013/03/06 ...
7 years, 5 months ago (2013-03-06 20:30:44 UTC) #5
rog
LGTM with one trivial https://codereview.appspot.com/7444052/diff/13001/state/api/params/params.go File state/api/params/params.go (right): https://codereview.appspot.com/7444052/diff/13001/state/api/params/params.go#newcode74 state/api/params/params.go:74: // CharmInfo stores parameters for ...
7 years, 5 months ago (2013-03-06 20:33:03 UTC) #6
frankban
Thanks for the reviews Roger and Dimiter.
7 years, 5 months ago (2013-03-06 20:41:15 UTC) #7
frankban
7 years, 5 months ago (2013-03-06 20:42:53 UTC) #8
*** Submitted:

Add a CharmInfo API command.

Add a CharmInfo API command to get information 
about a charm, given its URL. It is needed by the 
Juju GUI, modeled upon the similar one in pyJuju.

R=dimitern, rog
CC=
https://codereview.appspot.com/7444052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b