Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1168)

Issue 7444048: code review 7444048: net/http: document net/http/cookiejar on CookieJar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bradfitz
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, nigeltao, adg
Visibility:
Public.

Description

net/http: document net/http/cookiejar on CookieJar

Patch Set 1 #

Patch Set 2 : diff -r 2f04e02f33c0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2f04e02f33c0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2f04e02f33c0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2f04e02f33c0 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 12dda72d9932 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/net/http/jar.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
bradfitz
Hello golang-dev@googlegroups.com, nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2013-03-01 00:33:11 UTC) #1
adg
On 1 March 2013 11:33, <bradfitz@golang.org> wrote: > +// The net/http/cookiejar package implements CookieJar. s/implements ...
12 years, 3 months ago (2013-03-01 00:37:01 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com, nigeltao@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 3 months ago (2013-03-01 00:38:33 UTC) #3
adg
LGTM
12 years, 3 months ago (2013-03-01 00:50:57 UTC) #4
adg
It'd be cool if godoc could automatically linkify "foo package" if foo is a valid ...
12 years, 3 months ago (2013-03-01 00:51:13 UTC) #5
bradfitz
Yes. File a bug? On Thu, Feb 28, 2013 at 4:51 PM, <adg@golang.org> wrote: > ...
12 years, 3 months ago (2013-03-01 00:57:58 UTC) #6
bradfitz
12 years, 3 months ago (2013-03-01 00:58:17 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=e749cebd59ee ***

net/http: document net/http/cookiejar on CookieJar

R=golang-dev, nigeltao, adg
CC=golang-dev
https://codereview.appspot.com/7444048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b