Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 7444046: Adding in lazy rendering of sub apps

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by jeff.pihach
Modified:
7 years, 8 months ago
Reviewers:
mp+151118, matthew.scott, gary.poster
Visibility:
Public.

Description

Adding in lazy rendering of sub apps https://code.launchpad.net/~hatch/juju-gui/1136431-lazy-render/+merge/151118 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Adding in lazy rendering of sub apps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M app/assets/javascripts/sub-app.js View 1 4 chunks +38 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
7 years, 8 months ago (2013-02-28 22:34:09 UTC) #1
gary.poster
LGTM. trivial suggestions. Thanks Gary https://codereview.appspot.com/7444046/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7444046/diff/1/app/app.js#newcode468 app/app.js:468: subApp._checkRendered(); trivial: If this ...
7 years, 8 months ago (2013-02-28 22:43:02 UTC) #2
matthew.scott
LGTM - one minor comment to take or leave if you wish, plus Gary's questions. ...
7 years, 8 months ago (2013-02-28 23:08:57 UTC) #3
jeff.pihach
Thanks for the reviews! Comments below https://codereview.appspot.com/7444046/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7444046/diff/1/app/app.js#newcode468 app/app.js:468: subApp._checkRendered(); On 2013/02/28 ...
7 years, 8 months ago (2013-02-28 23:27:27 UTC) #4
jeff.pihach
7 years, 8 months ago (2013-02-28 23:34:15 UTC) #5
*** Submitted:

Adding in lazy rendering of sub apps

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7444046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b