code review 74390043: cmd/gc: fix crash in -live mode

cmd/gc: fix crash in -live mode

debuglive >= 1 is not the condition under which we
start recording messages (we avoid printing for
init functions even if debuglive is set).

[rsc, 2014-03-12 02:48:51]

Hello golang-codereviews@googlegroups.com (cc: iant, khr),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-03-12 03:46:37]

LGTM



On Tue, Mar 11, 2014 at 7:48 PM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: iant, khr),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: fix crash in -live mode
>
> debuglive >= 1 is not the condition under which we
> start recording messages (we avoid printing for
> init functions even if debuglive is set).
>
> Please review this at https://codereview.appspot.com/74390043/
>
> Affected files (+2, -2 lines):
>   src/cmd/gc/plive.c
>
>
> Index: src/cmd/gc/plive.c
> ===================================================================
> --- a/src/cmd/gc/plive.c
> +++ b/src/cmd/gc/plive.c
> @@ -1607,7 +1607,7 @@
>                                 // We're interpreting the args and locals
> bitmap instead of liveout so that we
>                                 // include the bits added by the avarinit
> logic in the
>                                 // previous loop.
> -                               if(debuglive >= 1) {
> +                               if(msg != nil) {
>                                         fmtstrinit(&fmt);
>                                         fmtprint(&fmt, "%L: live at ",
> p->lineno);
>                                         if(p->as == ACALL && p->to.node)
> @@ -1657,7 +1657,7 @@
>                                 pos--;
>                         }
>                 }
> -               if(debuglive >= 1) {
> +               if(msg != nil) {
>                         for(j=startmsg; j<nmsg; j++)
>                                 if(msg[j] != nil)
>                                         print("%s", msg[j]);
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-03-12 03:55:15]

LGTM

On Tue, Mar 11, 2014 at 8:46 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
>
>
> On Tue, Mar 11, 2014 at 7:48 PM, <rsc@golang.org> wrote:
>>
>> Reviewers: golang-codereviews,
>>
>> Message:
>> Hello golang-codereviews@googlegroups.com (cc: iant, khr),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> cmd/gc: fix crash in -live mode
>>
>> debuglive >= 1 is not the condition under which we
>> start recording messages (we avoid printing for
>> init functions even if debuglive is set).
>>
>> Please review this at https://codereview.appspot.com/74390043/
>>
>> Affected files (+2, -2 lines):
>>   src/cmd/gc/plive.c
>>
>>
>> Index: src/cmd/gc/plive.c
>> ===================================================================
>> --- a/src/cmd/gc/plive.c
>> +++ b/src/cmd/gc/plive.c
>> @@ -1607,7 +1607,7 @@
>>                                 // We're interpreting the args and locals
>> bitmap instead of liveout so that we
>>                                 // include the bits added by the avarinit
>> logic in the
>>                                 // previous loop.
>> -                               if(debuglive >= 1) {
>> +                               if(msg != nil) {
>>                                         fmtstrinit(&fmt);
>>                                         fmtprint(&fmt, "%L: live at ",
>> p->lineno);
>>                                         if(p->as == ACALL && p->to.node)
>> @@ -1657,7 +1657,7 @@
>>                                 pos--;
>>                         }
>>                 }
>> -               if(debuglive >= 1) {
>> +               if(msg != nil) {
>>                         for(j=startmsg; j<nmsg; j++)
>>                                 if(msg[j] != nil)
>>                                         print("%s", msg[j]);
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>

[rsc, 2014-03-12 03:58:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=a1b77145c1fb ***

cmd/gc: fix crash in -live mode

debuglive >= 1 is not the condition under which we
start recording messages (we avoid printing for
init functions even if debuglive is set).

LGTM=bradfitz, iant
R=golang-codereviews, bradfitz
CC=golang-codereviews, iant, khr
https://codereview.appspot.com/74390043

[gobot, 2014-03-12 05:42:16]

This CL appears to have broken the darwin-amd64-race-cheney builder.