Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 7438053: code review 7438053: syscall: add PROT_* and MAP_* constants to freebsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dave
Modified:
12 years, 2 months ago
Reviewers:
CC:
dho, minux1, rsc, golang-dev
Visibility:
Public.

Description

syscall: add PROT_* and MAP_* constants to freebsd Update issue 4929 Regenerated from FreeBSD-9.1 for amd64 and 386, FreeBSD-CURRENT for arm.

Patch Set 1 #

Patch Set 2 : diff -r 1b4b6a694b1c https://code.google.com/p/go #

Patch Set 3 : diff -r 326a3ee842a2 https://code.google.com/p/go #

Patch Set 4 : diff -r 3d1a771ddcc5 https://code.google.com/p/go #

Patch Set 5 : diff -r 3d1a771ddcc5 https://code.google.com/p/go #

Patch Set 6 : diff -r 3d1a771ddcc5 https://code.google.com/p/go #

Patch Set 7 : diff -r 3d1a771ddcc5 https://code.google.com/p/go #

Patch Set 8 : diff -r 802cd834d1f7 https://code.google.com/p/go #

Patch Set 9 : diff -r 802cd834d1f7 https://code.google.com/p/go #

Patch Set 10 : diff -r 802cd834d1f7 https://code.google.com/p/go #

Patch Set 11 : diff -r 9540d43f0171 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -14 lines) Patch
M src/pkg/syscall/mkerrors.sh View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 1 2 3 4 5 6 7 8 33 chunks +200 lines, -4 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 1 2 3 4 5 6 7 8 33 chunks +200 lines, -4 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_arm.go View 1 2 3 4 5 6 7 8 7 chunks +42 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_386.go View 1 3 chunks +3 lines, -1 line 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_amd64.go View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M src/pkg/syscall/zsysnum_freebsd_arm.go View 1 2 3 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7
dave_cheney.net
Hello devon.odell@gmail.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-03-02 05:51:54 UTC) #1
dave_cheney.net
Hello devon.odell@gmail.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 3 months ago (2013-03-02 21:17:08 UTC) #2
rsc
LGTM assuming the O_CLOEXEC change is no longer here (I don't see it).
12 years, 3 months ago (2013-03-04 15:16:57 UTC) #3
dho
On 2013/03/04 15:16:57, rsc wrote: > LGTM assuming the O_CLOEXEC change is no longer here ...
12 years, 3 months ago (2013-03-04 17:22:09 UTC) #4
minux1
LGTM.
12 years, 3 months ago (2013-03-04 17:27:08 UTC) #5
dave_cheney.net
Thanks, yes the O_CLOEXEC change was removed from this proposal. On Mon, Mar 4, 2013 ...
12 years, 3 months ago (2013-03-04 17:46:15 UTC) #6
dave_cheney.net
12 years, 2 months ago (2013-03-09 05:25:45 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=83b0b94af636 ***

syscall: add PROT_* and MAP_* constants to freebsd

Update issue 4929

Regenerated from FreeBSD-9.1 for amd64 and 386, FreeBSD-CURRENT for arm.

R=devon.odell, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/7438053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b