Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(550)

Issue 7437043: code review 7437043: cmd/gc: unbreak exporting of composite literals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by remyoudompheng
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, dave_cheney.net, rsc
Visibility:
Public.

Description

cmd/gc: unbreak exporting of composite literals. Fixes issue 4932.

Patch Set 1 #

Patch Set 2 : diff -r 38b1893be35d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 38b1893be35d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cc047c2dc1ea https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -19 lines) Patch
M src/cmd/gc/fmt.c View 1 2 5 chunks +22 lines, -9 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/subr.c View 1 2 chunks +13 lines, -1 line 0 comments Download
M src/cmd/gc/typecheck.c View 1 6 chunks +10 lines, -9 lines 0 comments Download
A test/fixedbugs/issue4932.go View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4932.dir/foo.go View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4932.dir/state.go View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4932.dir/state2.go View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 2 months ago (2013-02-28 23:54:07 UTC) #1
dave_cheney.net
On 2013/02/28 23:54:07, remyoudompheng wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
11 years, 2 months ago (2013-03-01 00:15:44 UTC) #2
remyoudompheng
ping I would like to submit this tomorrow, unless somebody expresses concern about code ugliness.
11 years, 1 month ago (2013-03-03 10:39:25 UTC) #3
rsc
LGTM
11 years, 1 month ago (2013-03-04 15:21:58 UTC) #4
remyoudompheng
11 years, 1 month ago (2013-03-04 15:42:17 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=349307ceff90 ***

cmd/gc: unbreak exporting of composite literals.

Fixes issue 4932.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/7437043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b