Issue 7434047: code review 7434047: net/http/cgi: disable TestCopyError to try to fix darwi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7434047: code review 7434047: net/http/cgi: disable TestCopyError to try to fix darwi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:
minux1

CC:
golang-dev

Visibility:
Public.

Description

net/http/cgi: disable TestCopyError to try to fix darwin/386 on builder Update issue 4958.

Patch Set 1 #

Patch Set 2 : diff -r 9922f691ffd1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9922f691ffd1 https://code.google.com/p/go/ #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/pkg/net/http/cgi/host_test.go	View	1	1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-03-01 17:00:22 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=3b6a919034af *** net/http/cgi: disable TestCopyError to try to fix darwin/386 on builder ...

12 years, 3 months ago (2013-03-01 17:00:29 UTC) #2

minux1

12 years, 3 months ago (2013-03-01 17:02:45 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.appspot.com/7434047/diff/3/src/pkg/net/http/cgi/host_test.go
File src/pkg/net/http/cgi/host_test.go (right):

https://codereview.appspot.com/7434047/diff/3/src/pkg/net/http/cgi/host_test....
src/pkg/net/http/cgi/host_test.go:305: t.Skipf("issue 4958 - skipping test on
darwin")
s/Skipf/Skip/, but OK.

Expand All Messages | Collapse All Messages