Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 7432048: code review 7432048: cmd/cgo: use explicit flag to emit dynamic linker path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

cmd/cgo: use explicit flag to emit dynamic linker path Using -import_runtime_cgo would have worked great except that it doesn't get passed to the second invocation of cgo, and that's the one that writes the relevant file. Fixes ARM build on systems with a different dynamic linker than the one 5l assumes (like Gentoo).

Patch Set 1 #

Patch Set 2 : diff -r 16c93a202587 https://code.google.com/p/go #

Patch Set 3 : diff -r 16c93a202587 https://code.google.com/p/go #

Patch Set 4 : diff -r 641f05de9e68 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/cmd/cgo/main.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/cgo/out.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/go/build.go View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-03-01 19:53:59 UTC) #1
minux1
please see my comment in https://codereview.appspot.com/7433043/#msg7. if we want to distribute cgo-enabled arm binary distributions, ...
12 years ago (2013-03-01 19:58:10 UTC) #2
rsc
PTAL (nothing changed) I believe that this CL is fine as is. I understand the ...
12 years ago (2013-03-04 14:58:40 UTC) #3
minux1
LGTM. On Mon, Mar 4, 2013 at 10:58 PM, Russ Cox <rsc@golang.org> wrote: > 1) ...
12 years ago (2013-03-04 16:13:48 UTC) #4
rsc
12 years ago (2013-03-04 16:23:21 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=f545866390ab ***

cmd/cgo: use explicit flag to emit dynamic linker path

Using -import_runtime_cgo would have worked great except
that it doesn't get passed to the second invocation of cgo,
and that's the one that writes the relevant file.

Fixes ARM build on systems with a different dynamic linker
than the one 5l assumes (like Gentoo).

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7432048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b