Issue 7431054: code review 7431054: text/template/parse: remove self-assignment.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7431054: code review 7431054: text/template/parse: remove self-assignment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dsymonds

Modified:
12 years ago

Reviewers:

CC:
golang-dev, adg1

Visibility:
Public.

Description

text/template/parse: remove self-assignment.

Patch Set 1 #

Patch Set 2 : diff -r eb28a75cdc40 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eb28a75cdc40 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eb28a75cdc40 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/pkg/text/template/parse/parse.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-04 23:05:25 UTC) #1

dsymonds

12 years ago (2013-03-05 00:17:05 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0e1b7425101a ***

text/template/parse: remove self-assignment.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7431054

Expand All Messages | Collapse All Messages