code review 7430044: syscall: add {Set,Get}priority for Linux, and consisten...

syscall: add {Set,Get}priority for Linux, and consistency tests

[minux1, 2013-02-28 18:43:39]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-02-28 18:44:43]

*BSD already contains those two syscalls, but not required constants.

the consistency check is RFC.

[iant, 2013-02-28 18:59:52]

Looks basically fine but clearly we can not commit it until the syscall is added
to the other Unix systems, or the test is moved to a different CL.

I would be curious to hear what others think of the test approach.

[minux1, 2013-02-28 19:05:28]

On Fri, Mar 1, 2013 at 2:59 AM, <iant@golang.org> wrote:

> Looks basically fine but clearly we can not commit it until the syscall
> is added to the other Unix systems, or the test is moved to a different
> CL.
>
To be clear, *BSD (including Darwin) already defines the two syscalls.
(if none of them has those two syscalls, I doubt we can add new APIs
at this stage)
I only added the syscalls to Linux and the three required constants to
all Unixes to be consistent and make them usable on *BSDs.

>
> I would be curious to hear what others think of the test approach.
>
me too.

[bradfitz, 2013-02-28 21:24:45]

https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_...
File src/pkg/syscall/consistency_unix_test.go (right):

https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_...
src/pkg/syscall/consistency_unix_test.go:15: func _() {
why do these vars and consts need to be in a func?

[dave_cheney.net, 2013-02-28 23:29:45]

LGTM. The only comment I have is on the name of the test file,
consistent_unix_test.go doens't really tell me much about what it does. What
about

   syscall_unix_test.go

we already have a syscall_windows_test.go

https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_...
File src/pkg/syscall/consistency_unix_test.go (right):

https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_...
src/pkg/syscall/consistency_unix_test.go:14: // {Set,Get}priority and needed
constants for them
// issue NNNN.

/s/needed/required/

[minux1, 2013-03-04 18:52:07]

any more opinions on this?

[adg, 2013-03-05 23:37:37]

I think it might be too late for this, and would urge you to leave it until
after Go 1.1 unless you feel very strongly about it.

http://golang.org/s/go11freeze

[bradfitz, 2013-06-05 01:09:16]

ping

[minux1, 2013-06-09 14:51:27]

PTAL.

[iant, 2013-06-10 18:01:59]

LGTM

[minux1, 2013-06-10 18:47:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=b08e22305bcc ***

syscall: add {Set,Get}priority for Linux, and consistency tests

R=golang-dev, iant, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/7430044