Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 7430043: Set callback scope depending on namespace

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by jeff.pihach
Modified:
7 years, 8 months ago
Reviewers:
mp+150950, bcsaller, gary.poster
Visibility:
Public.

Description

Set callback scope depending on namespace https://code.launchpad.net/~hatch/juju-gui/1134850-callback-scope/+merge/150950 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set callback scope depending on namespace #

Patch Set 3 : Set callback scope depending on namespace #

Patch Set 4 : Set callback scope depending on namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 3 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
7 years, 8 months ago (2013-02-28 03:32:59 UTC) #1
gary.poster
LGTM. Thanks! Gary
7 years, 8 months ago (2013-02-28 04:00:34 UTC) #2
bcsaller
LGTM with trivial. Thanks https://codereview.appspot.com/7430043/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7430043/diff/1/app/app.js#newcode470 app/app.js:470: callingContext = self; If we ...
7 years, 8 months ago (2013-02-28 14:57:34 UTC) #3
jeff.pihach
Thanks for the reviews! https://codereview.appspot.com/7430043/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7430043/diff/1/app/app.js#newcode470 app/app.js:470: callingContext = self; On 2013/02/28 ...
7 years, 8 months ago (2013-02-28 16:09:00 UTC) #4
jeff.pihach
7 years, 8 months ago (2013-02-28 16:18:25 UTC) #5
*** Submitted:

Set callback scope depending on namespace

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7430043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b