Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 7429044: Route namespace property stays in route

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by jeff.pihach
Modified:
7 years, 8 months ago
Reviewers:
bcsaller, mp+151027, gary.poster
Visibility:
Public.

Description

Route namespace property stays in route https://code.launchpad.net/~hatch/juju-gui/1135819-route-namespace/+merge/151027 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Route namespace property stays in route #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 1 chunk +18 lines, -15 lines 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
7 years, 8 months ago (2013-02-28 14:50:35 UTC) #1
bcsaller
LGTM But to be fair I don't know if I can review this as I ...
7 years, 8 months ago (2013-02-28 15:27:15 UTC) #2
gary.poster
LGTM with trivials. Thanks! Gary https://codereview.appspot.com/7429044/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7429044/diff/1/app/app.js#newcode1077 app/app.js:1077: * default interface which ...
7 years, 8 months ago (2013-02-28 16:01:31 UTC) #3
bcsaller
https://codereview.appspot.com/7429044/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7429044/diff/1/app/app.js#newcode1083 app/app.js:1083: callbacks = Y.Array.flatten(callbacks); On 2013/02/28 16:01:31, gary.poster wrote: > ...
7 years, 8 months ago (2013-02-28 16:21:00 UTC) #4
jeff.pihach
Thanks for the reviews! See the comments below. https://codereview.appspot.com/7429044/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7429044/diff/1/app/app.js#newcode1077 app/app.js:1077: * ...
7 years, 8 months ago (2013-02-28 20:10:09 UTC) #5
jeff.pihach
7 years, 8 months ago (2013-02-28 20:16:26 UTC) #6
*** Submitted:

Route namespace property stays in route

R=bcsaller, gary.poster
CC=
https://codereview.appspot.com/7429044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b