Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)

Issue 7427044: OSX Package Installer: handle previous installation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by TylerB
Modified:
12 years ago
Reviewers:
dave
CC:
adg, golang-dev
Visibility:
Public.

Description

OSX Package Installer: handle previous installation The installer package will now detect a previous installation and warn the user that the previous installation will be deleted. If the user continues, the installer will delete the previous installation and install the package as usual. Fixes issue 4293.

Patch Set 1 #

Patch Set 2 : diff -r 10f4568ce780 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M misc/dist/darwin/Distribution View 1 1 chunk +7 lines, -1 line 0 comments Download
A misc/dist/darwin/scripts/preinstall View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
LGTM
12 years ago (2013-02-28 05:08:49 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=81b7029c7205 *** misc/dist: handle previous installation The installer package will now detect ...
12 years ago (2013-02-28 05:09:55 UTC) #2
dave_cheney.net
12 years ago (2013-02-28 07:19:08 UTC) #3
Awesome!

On 28/02/2013, at 16:09, adg@golang.org wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=81b7029c7205 ***
> 
> misc/dist: handle previous installation
> 
> The installer package will now detect a previous installation and warn
> the user
> that the previous installation will be deleted. If the user continues,
> the
> installer will delete the previous installation and install the package
> as
> usual.
> 
> Fixes issue 4293.
> 
> R=adg
> CC=golang-dev
> https://codereview.appspot.com/7427044
> 
> Committer: Andrew Gerrand <adg@golang.org>
> 
> 
> https://codereview.appspot.com/7427044/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b