Issue 7425043: code review 7425043: exp/cookiejar: eliminate some "."+str garbage.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7425043: code review 7425043: exp/cookiejar: eliminate some "."+str garbage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by nigeltao

Modified:
12 years, 3 months ago

Reviewers:

CC:
dsymonds, volker.dobler, golang-dev

Visibility:
Public.

Description

exp/cookiejar: eliminate some "."+str garbage. It's not a big deal, but it's easy to fix.

Patch Set 1 #

Patch Set 2 : diff -r c3733f9d8642 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c3733f9d8642 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r c3733f9d8642 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -3 lines)			Patch
	M	src/pkg/exp/cookiejar/jar.go	View	1	4 chunks	+8 lines, -3 lines	0 comments	Download
	M	src/pkg/exp/cookiejar/jar_test.go	View	1	1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello dsymonds@golang.org (cc: dr.volker.dobler@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-02-28 00:50:23 UTC) #1

dsymonds

LGTM, I guess. It's an easy fix, but does make the code a bit less ...

12 years, 3 months ago (2013-02-28 01:13:00 UTC) #2

nigeltao

12 years, 3 months ago (2013-02-28 02:46:51 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=10f4568ce780 ***

exp/cookiejar: eliminate some "."+str garbage.

It's not a big deal, but it's easy to fix.

R=dsymonds
CC=dr.volker.dobler, golang-dev
https://codereview.appspot.com/7425043

Expand All Messages | Collapse All Messages