Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(941)

Issue 7424046: revert only r943 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by jameinel
Modified:
11 years, 1 month ago
Reviewers:
mp+151005
Visibility:
Public.

Description

revert only r943 William merged a change which reverted trunk back to 942 because rev 943 broke the test suite. This just re-introduces all of the merges 944-947, so that Gustavo and Ian don't have to re-propose and get approval for their changes again. I've run the test suite to make sure it passes as long as just 943 has been removed. In the future, you can just cherrypick-out specific revisions with (eg): bzr merge . -r 943..942 And then run the test suite, and propose it. (Which is essentially what this patch does, except it also reverts 948 which removed all of those other revisions.) https://code.launchpad.net/~jameinel/juju-core/only-943/+merge/151005 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : revert only r943 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -125 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/cmd.go View 1 chunk +6 lines, -1 line 0 comments Download
M cmd/cmd_test.go View 7 chunks +7 lines, -7 lines 0 comments Download
M cmd/filevar_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/addrelation_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/addunit_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/bootstrap_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/cmd_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/config_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M cmd/juju/constraints_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/deploy_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/destroymachine_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/destroyrelation_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/destroyservice_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/destroyunit_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/expose_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/init_test.go View 4 chunks +5 lines, -5 lines 0 comments Download
M cmd/juju/resolved_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/scp_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/ssh_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/status_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/unexpose_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/upgradejuju_test.go View 3 chunks +2 lines, -3 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/bootstrap_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/logging_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M cmd/output_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M cmd/supercommand_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/util_test.go View 1 chunk +0 lines, -5 lines 0 comments Download
M environs/agent/agent.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/api.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/conn.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/api/api_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/api/error.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/open.go View 4 chunks +28 lines, -5 lines 0 comments Download
M state/state_test.go View 4 chunks +5 lines, -5 lines 0 comments Download
M state/unit_test.go View 1 chunk +1 line, -1 line 0 comments Download
M store/server.go View 3 chunks +67 lines, -2 lines 0 comments Download
M store/server_test.go View 3 chunks +47 lines, -4 lines 0 comments Download
M store/store.go View 8 chunks +164 lines, -19 lines 0 comments Download
M store/store_test.go View 3 chunks +60 lines, -3 lines 0 comments Download
M testing/cmd.go View 1 chunk +27 lines, -4 lines 0 comments Download
M worker/uniter/jujuc/config-get_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M worker/uniter/jujuc/ports_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/jujuc/relation-get_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M worker/uniter/jujuc/relation-ids_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M worker/uniter/jujuc/relation-list_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M worker/uniter/jujuc/relation-set_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/uniter/jujuc/server.go View 1 chunk +6 lines, -1 line 0 comments Download
M worker/uniter/jujuc/unit-get_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M worker/uniter/jujuc/util_test.go View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
11 years, 2 months ago (2013-02-28 12:31:04 UTC) #1
wallyworld
LGTM. Thanks for doing this.
11 years, 2 months ago (2013-02-28 12:55:26 UTC) #2
fwereade
LGTM -- thank you very much.
11 years, 2 months ago (2013-02-28 13:05:14 UTC) #3
jameinel
11 years, 2 months ago (2013-02-28 13:09:03 UTC) #4
*** Submitted:

revert only r943

William merged a change which reverted trunk back to 942
because rev 943 broke the test suite.

This just re-introduces all of the merges 944-947, so that
Gustavo and Ian don't have to re-propose and get approval
for their changes again.

I've run the test suite to make sure it passes as long as
just 943 has been removed.

In the future, you can just cherrypick-out specific revisions
with (eg):
 bzr merge . -r 943..942

And then run the test suite, and propose it. (Which is essentially
what this patch does, except it also reverts 948 which removed
all of those other revisions.)

R=wallyworld, fwereade
CC=
https://codereview.appspot.com/7424046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b