Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1041)

Issue 7424044: code review 7424044: go.net/html: don't use Go tip io.ByteWriter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by minux1
Modified:
8 years, 10 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

go.net/html: don't use Go tip io.ByteWriter So that Go 1.0 user could also use this package. Fixes issue 4931.

Patch Set 1 #

Patch Set 2 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 3 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 4 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 5 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M html/render.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
8 years, 10 months ago (2013-02-28 08:08:04 UTC) #1
dsymonds
LGTM
8 years, 10 months ago (2013-02-28 08:15:52 UTC) #2
minux1
8 years, 10 months ago (2013-02-28 08:17:30 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=f7f5159120f5&repo=net ***

go.net/html: don't use Go tip io.ByteWriter
So that Go 1.0 user could also use this package.
Fixes issue 4931.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/7424044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b