Issue 7424043: code review 7424043: path/filepath: better error reporting during TestWinSpl...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7424043: code review 7424043: path/filepath: better error reporting during TestWinSpl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by brainman

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

path/filepath: better error reporting during TestWinSplitListTestsAreValid Fixes issue 4930.

Patch Set 1 #

Patch Set 2 : diff -r c3733f9d8642 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c3733f9d8642 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 000120ff858a https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/path/filepath/path_windows_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2013-02-28 00:31:26 UTC) #1

brainman

12 years, 3 months ago (2013-03-01 03:50:02 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2559767daf2a ***

path/filepath: better error reporting during TestWinSplitListTestsAreValid

Fixes issue 4930.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7424043

Expand All Messages | Collapse All Messages