code review 74230043: go.tools/dashboard/builder: always cross compile for na...

go.tools/dashboard/builder: always cross compile for nacl builds

If we are building, for example, linux/386 on a linux/amd64 machine we want to make sure that the whole build is done as a if this were compiled on a real linux/386 machine. In other words, we want to not do a cross compilation build.

The exception to this rule is when we are doing nacl builds. These are by definition always cross compilation, and we have support built into cmd/go to be able to handle this case.

[dave_cheney.net, 2014-03-11 21:41:55]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-03-11 21:49:44]

LGTM but remove the all-caps banner first



On Tue, Mar 11, 2014 at 2:41 PM, <dave@cheney.net> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/dashboard/builder: always cross compile for nacl builds
>
> *** NOT FOR SUBMISSION ***
>
> Please review this at https://codereview.appspot.com/74230043/
>
> Affected files (+11, -2 lines):
>   M dashboard/builder/env.go
>
>
> Index: dashboard/builder/env.go
> ===================================================================
> --- a/dashboard/builder/env.go
> +++ b/dashboard/builder/env.go
> @@ -54,11 +54,20 @@
>         if *buildTool == "go" {
>                 e = []string{
>                         "GOOS=" + b.goos,
> -                       "GOHOSTOS=" + b.goos,
>                         "GOARCH=" + b.goarch,
> -                       "GOHOSTARCH=" + b.goarch,
>                         "GOROOT_FINAL=/usr/local/go",
>                 }
> +               if b.goos != "nacl" {
> +                       // If we are building, for example, linux/386 on a
> linux/amd64 machine we want to
> +                       // make sure that the whole build is done as a if
> this were compiled on a real
> +                       // linux/386 machine. In other words, we want to
> not do a cross compilation build.
> +                       // To do this we set GOHOSTOS and GOHOSTARCH to
> override the detection in make.bash.
> +                       //
> +                       // The exception to this rule is when we are doing
> nacl builds. These are by definition
> +                       // always cross compilation, and we have support
> built into cmd/go to be able to handle
> +                       // this case.
> +                       e = append(e, "GOHOSTOS="+b.goos,
> "GOHOSTARCH="+b.goarch)
> +               }
>         }
>
>         for _, k := range extraEnv {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dave_cheney.net, 2014-03-11 21:57:52]

PTAL. Description updated

[bradfitz, 2014-03-11 22:00:19]

LGTM

[dave_cheney.net, 2014-03-11 22:52:18]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b62a410dba52&repo=tools ***

go.tools/dashboard/builder: always cross compile for nacl builds

If we are building, for example, linux/386 on a linux/amd64 machine we want to
make sure that the whole build is done as a if this were compiled on a real
linux/386 machine. In other words, we want to not do a cross compilation build.

The exception to this rule is when we are doing nacl builds. These are by
definition always cross compilation, and we have support built into cmd/go to be
able to handle this case.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/74230043