code review 7422055: archive/tar: remove execute bit from common.go

archive/tar: remove execute bit from common.go

[adg, 2013-03-02 21:53:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-03-02 21:54:55]

LGTM. Where do these keep coming from ?

On Sun, Mar 3, 2013 at 8:53 AM,  <adg@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> archive/tar: remove execute bit from common.go
>
> Please review this at https://codereview.appspot.com/7422055/
>
> Affected files:
>   M src/pkg/archive/tar/common.go
>
>
> Index: src/pkg/archive/tar/common.go
> ===================================================================
> old mode 100755
> new mode 100644
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[adg, 2013-03-02 21:56:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=677c9ac552ac ***

archive/tar: remove execute bit from common.go

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7422055

[minux1, 2013-03-02 21:57:24]

On Sun, Mar 3, 2013 at 5:54 AM, Dave Cheney <dave@cheney.net> wrote:

> Where do these keep coming from ?

shall we add a check to the codereview plugin so that to submit
CL with executable files, one must explicitly add a command line
option to "hg submit"?

[dave_cheney.net, 2013-03-02 22:33:57]

Maybe a simpler option would be to disallow executable .go files, while in sure
there are exceptions, all of the recent commits that fix mode bits, have been
.go files. 

On 03/03/2013, at 8:57, minux <minux.ma@gmail.com> wrote:

> 
> On Sun, Mar 3, 2013 at 5:54 AM, Dave Cheney <dave@cheney.net> wrote:
>> Where do these keep coming from ?
> shall we add a check to the codereview plugin so that to submit
> CL with executable files, one must explicitly add a command line
> option to "hg submit"?

[adg, 2013-03-04 06:50:36]

Rather than hacking on codereview.py more (shudder) we could add a test to
all.bash that checks for bad permissions on go files in the tree.

I don't think it's a big enough issue to spend much time on, though.


On 3 March 2013 09:33, Dave Cheney <dave@cheney.net> wrote:

> Maybe a simpler option would be to disallow executable .go files, while in
> sure there are exceptions, all of the recent commits that fix mode bits,
> have been .go files.
>
> On 03/03/2013, at 8:57, minux <minux.ma@gmail.com> wrote:
>
>
> On Sun, Mar 3, 2013 at 5:54 AM, Dave Cheney <dave@cheney.net> wrote:
>
>> Where do these keep coming from ?
>
> shall we add a check to the codereview plugin so that to submit
> CL with executable files, one must explicitly add a command line
> option to "hg submit"?
>
>