Issue 7422054: code review 7422054: runtime: fix false positive deadlock when using runtime...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7422054: code review 7422054: runtime: fix false positive deadlock when using runtime... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dvyukov

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix false positive deadlock when using runtime.Goexit Fixes issue 4893. Actually it's fixed by cl/7314062 (improved scheduler), just submitting the test.

Patch Set 1 #

Patch Set 2 : diff -r b31de657acdb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b31de657acdb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 2344e072a1f6 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/pkg/runtime/crash_test.go	View	1 2 3	2 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 1 month ago (2013-03-02 07:00:00 UTC) #1

dvyukov

12 years, 1 month ago (2013-03-05 07:46:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cfd3b3ecbfe9 ***

runtime: fix false positive deadlock when using runtime.Goexit
Fixes issue 4893.
Actually it's fixed by cl/7314062 (improved scheduler),
just submitting the test.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7422054

Expand All Messages | Collapse All Messages