Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 74220043: code review 74220043: runtime: disable Native Client fake time support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dave
Modified:
11 years, 9 months ago
Reviewers:
gobot, bradfitz
CC:
rsc, bradfitz, golang-codereviews
Visibility:
Public.

Description

runtime: disable Native Client fake time support This CL is a reformulation of CL 73110043 containing only the minimum required to get the nacl builds compiling.

Patch Set 1 #

Patch Set 2 : code review 74220043: runtime: disable Native Client fake time support #

Patch Set 3 : diff -r 104004fc1da3 https://code.google.com/p/go #

Patch Set 4 : diff -r 104004fc1da3 https://code.google.com/p/go #

Patch Set 5 : diff -r ac22f24159cc https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/pkg/runtime/time.goc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Hello rsc@golang.org, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 9 months ago (2014-03-11 21:01:19 UTC) #1
bradfitz
LGTM
11 years, 9 months ago (2014-03-11 21:21:01 UTC) #2
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=3a45c66fe455 *** runtime: disable Native Client fake time support This CL is ...
11 years, 9 months ago (2014-03-11 21:56:14 UTC) #3
bradfitz
Further: http://build.golang.org/log/ae069677b83f09e5380971dde1ca800658cf7dd9 On Tue, Mar 11, 2014 at 2:56 PM, <dave@cheney.net> wrote: > *** Submitted ...
11 years, 9 months ago (2014-03-11 22:00:48 UTC) #4
gobot
This CL appears to have broken the openbsd-386-rootbsd builder.
11 years, 9 months ago (2014-03-11 22:05:37 UTC) #5
dave_cheney.net
11 years, 9 months ago (2014-03-11 22:45:11 UTC) #6
Yup, that is expected. This is the current state of affairs.


On Wed, Mar 12, 2014 at 9:00 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Further:
> http://build.golang.org/log/ae069677b83f09e5380971dde1ca800658cf7dd9
>
>
>
> On Tue, Mar 11, 2014 at 2:56 PM, <dave@cheney.net> wrote:
>>
>> *** Submitted as
>> https://code.google.com/p/go/source/detail?r=3a45c66fe455 ***
>>
>>
>> runtime: disable Native Client fake time support
>>
>> This CL is a reformulation of CL 73110043 containing only the minimum
>> required to get the nacl builds compiling.
>>
>> LGTM=bradfitz
>> R=rsc, bradfitz
>> CC=golang-codereviews
>> https://codereview.appspot.com/74220043
>>
>>
>> https://codereview.appspot.com/74220043/
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b