Issue 7421050: code review 7421050: spec: cyclic imports are illegal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7421050: code review 7421050: spec: cyclic imports are illegal (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by gri

Modified:
12 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

spec: cyclic imports are illegal Fixes issue 4976.

Patch Set 1 #

Patch Set 2 : diff -r f545866390ab https://code.google.com/p/go #

Patch Set 3 : diff -r f545866390ab https://code.google.com/p/go #

Patch Set 4 : diff -r 120c70d13b95 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-03-04 20:32:18 UTC) #1

gri

12 years ago (2013-03-04 21:00:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=34970cca174d ***

spec: cyclic imports are illegal

Fixes issue 4976.

R=r
CC=golang-dev
https://codereview.appspot.com/7421050

Expand All Messages | Collapse All Messages