Issue 7421045: Implement the API unexpose command.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7421045: Implement the API unexpose command.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by frankban

Modified:
11 years, 2 months ago

Reviewers:
dimitern, mp+151055, rog

Visibility:
Public.

Description

Implement the API unexpose command. Moved the unexpose command logic to the statecmd package. Added tests, verified also running manual tests using a websocket connection. https://code.launchpad.net/~frankban/juju-core/bug-1130161-api-unexpose/+merge/151055 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement the API unexpose command. #

Patch Set 3 : Implement the API unexpose command. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/unexpose.go	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	state/api/api_test.go	View	1	3 chunks	+28 lines, -0 lines	0 comments	Download
M	state/api/apiclient.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	state/api/apiserver.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	state/statecmd/unexpose.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
A	state/statecmd/unexpose_test.go	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dimitern

LGTM with a trivial suggestion. https://codereview.appspot.com/7421045/diff/1/state/statecmd/unexpose_test.go File state/statecmd/unexpose_test.go (right): https://codereview.appspot.com/7421045/diff/1/state/statecmd/unexpose_test.go#newcode19 state/statecmd/unexpose_test.go:19: initialExposure bool It think ...

11 years, 2 months ago (2013-02-28 17:23:14 UTC) #2

frankban

Please take a look. https://codereview.appspot.com/7421045/diff/1/state/statecmd/unexpose_test.go File state/statecmd/unexpose_test.go (right): https://codereview.appspot.com/7421045/diff/1/state/statecmd/unexpose_test.go#newcode19 state/statecmd/unexpose_test.go:19: initialExposure bool On 2013/02/28 17:23:14, ...

11 years, 2 months ago (2013-03-01 10:03:40 UTC) #3

frankban

11 years, 2 months ago (2013-03-01 11:37:43 UTC) #6

*** Submitted:

Implement the API unexpose command.

Moved the unexpose command logic to the
statecmd package. Added tests, verified 
also running manual tests using a websocket
connection.

R=dimitern, rog
CC=
https://codereview.appspot.com/7421045

Expand All Messages | Collapse All Messages