Issue 7420052: code review 7420052: cmd/ld, runtime/cgo: allow a symbol to be both cgo_expo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7420052: code review 7420052: cmd/ld, runtime/cgo: allow a symbol to be both cgo_expo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by minux1

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/ld, runtime/cgo: allow a symbol to be both cgo_export and cgo_import. Fixes issue 4878.

Patch Set 2 : diff -r b0c8d47acfc5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b0c8d47acfc5 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r fa13899da667 https://code.google.com/p/go/ #

Patch Set 5 : diff -r c240597bbf3e https://code.google.com/p/go/ #

Patch Set 6 : diff -r 8eb88810d9d1 https://code.google.com/p/go/ #

Patch Set 7 : diff -r e48905a6e768 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
M	src/cmd/ld/go.c	View	1 2 3 4 5	1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_openbsd_386.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_openbsd_amd64.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/run.bash	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-03-02 16:40:46 UTC) #1

rsc

LGTM https://codereview.appspot.com/7420052/diff/5001/src/cmd/ld/go.c File src/cmd/ld/go.c (right): https://codereview.appspot.com/7420052/diff/5001/src/cmd/ld/go.c#newcode501 src/cmd/ld/go.c:501: // export overrides import // export overrides import, ...

12 years, 3 months ago (2013-03-04 15:08:32 UTC) #2

minux1

12 years, 2 months ago (2013-03-11 06:25:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=1da9617aaae9 ***

cmd/ld, runtime/cgo: allow a symbol to be both cgo_export and cgo_import.
Fixes issue 4878.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7420052

Expand All Messages | Collapse All Messages