Issue 7420045: code review 7420045: cmd/vet: %b is a valid floating-point format.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7420045: code review 7420045: cmd/vet: %b is a valid floating-point format. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by r

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

cmd/vet: %b is a valid floating-point format. Also add a report about "invalid type" from gotype, if -v is set.

Patch Set 1 #

Patch Set 2 : diff -r 21a8d1a6d1d6 https://code.google.com/p/go #

Patch Set 3 : diff -r 21a8d1a6d1d6 https://code.google.com/p/go #

Patch Set 4 : diff -r b4624f586699 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/cmd/vet/print.go	View	1 2	4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-28 01:13:15 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2013-02-28 01:17:18 UTC) #2

bradfitz

LGTM On Wed, Feb 27, 2013 at 5:17 PM, <r@golang.org> wrote: > Hello golang-dev@googlegroups.com (cc: ...

12 years, 3 months ago (2013-02-28 02:42:36 UTC) #3

12 years, 3 months ago (2013-02-28 19:32:56 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=46a4719077f3 ***

cmd/vet: %b is a valid floating-point format.
Also add a report about "invalid type" from gotype, if -v is set.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7420045

Expand All Messages | Collapse All Messages