charm: stream SHA256 of charm

charm: stream SHA256 of charm

There's no need to have the whole thing in
memory at once.

https://code.launchpad.net/~rogpeppe/juju-core/236-charm-stream-sha/+merge/151540

(do not edit description out of merge proposal)

[rog, 2013-03-04 15:56:42]

Please take a look.

[dimitern, 2013-03-04 16:04:58]

LGTM

[bac, 2013-03-04 16:34:07]

LGTM* assuming the tests are good and still pass.

* = not official juju-core reviewer

[dimitern, 2013-03-04 16:46:43]

On 2013/03/04 16:34:07, bac wrote:
> LGTM* assuming the tests are good and still pass.
> 
> * = not official juju-core reviewer

We're all in the same boat here. No need to be modest :)

[jameinel, 2013-03-04 22:30:30]

LGTM

[dave_cheney.net, 2013-03-13 02:15:37]

NOT LGTM. This code now leaks file handles.

https://codereview.appspot.com/7417051/diff/2001/charm/repo.go
File charm/repo.go (right):

https://codereview.appspot.com/7417051/diff/2001/charm/repo.go#newcode95
charm/repo.go:95: }
defer f.Close()

[rog, 2013-03-13 10:52:29]

On 2013/03/13 02:15:37, dfc wrote:
> NOT LGTM. This code now leaks file handles.
> 
> https://codereview.appspot.com/7417051/diff/2001/charm/repo.go
> File charm/repo.go (right):
> 
> https://codereview.appspot.com/7417051/diff/2001/charm/repo.go#newcode95
> charm/repo.go:95: }
> defer f.Close()

oops, how very embarrassing!

[rog, 2013-03-15 15:03:20]

*** Submitted:

charm: stream SHA256 of charm

There's no need to have the whole thing in
memory at once.

R=dimitern, bac, jameinel, dfc
CC=
https://codereview.appspot.com/7417051