Issue 7416044: code review 7416044: go.net/publicsuffix: build the full table from publicsu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7416044: code review 7416044: go.net/publicsuffix: build the full table from publicsu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by nigeltao

Modified:
12 years ago

Reviewers:

CC:
volker.dobler, golang-dev

Visibility:
Public.

Description

go.net/publicsuffix: build the full table from publicsuffix.org's effective_tld_names.dat, hg revision 3af9909a49e4 (2013-02-15).

Patch Set 1 #

Patch Set 2 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 3 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 4 : diff -r d48de3be16b3 https://code.google.com/p/go.net #

Patch Set 5 : diff -r f7f5159120f5 https://code.google.com/p/go.net #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18708 lines, -142 lines)			Patch
	M	publicsuffix/table.go	View	1 2 3	4 chunks	+6775 lines, -141 lines	0 comments	Download
	M	publicsuffix/table_test.go	View	1	12 chunks	+11933 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

12 years ago (2013-02-28 00:24:04 UTC) #1

nigeltao

Ah, s/2013-02-28/2013-02-15/, since it's the date of the effective_tld_names.dat hg revision, not the date that ...

12 years ago (2013-02-28 01:03:27 UTC) #2

nigeltao

12 years ago (2013-03-01 00:17:39 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=0cb28d13083d&repo=net ***

go.net/publicsuffix: build the full table from publicsuffix.org's
effective_tld_names.dat, hg revision 3af9909a49e4 (2013-02-15).

R=dr.volker.dobler
CC=golang-dev
https://codereview.appspot.com/7416044

Expand All Messages | Collapse All Messages