Issue 74160043: code review 74160043: runtime: build correct DLL for the arch.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 74160043: code review 74160043: runtime: build correct DLL for the arch.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by kardia

Modified:
10 years ago

Reviewers:
minux1, gobot, brainman, golang-codereviews

CC:
golang-codereviews

Visibility:
Public.

Description

runtime: build correct DLL for the arch. The DLL used to test callbacks should match the test executable's arch. Fixes issue 7513.

Patch Set 1 #

Patch Set 2 : diff -r c51e9abbb4fd https://code.google.com/p/go #

Patch Set 3 : diff -r c51e9abbb4fd https://code.google.com/p/go #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	src/pkg/runtime/syscall_windows_test.go	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kardia

Hello golang-codereviews@googlegroups.com (cc: alex.brainman@gmail.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-03-11 19:23:45 UTC) #1

brainman

On 2014/04/20 23:25:49, gobot wrote: > mailto:R=alex.brainman@gmail.com (assigned by mailto:minux.ma@gmail.com) We have decided https://code.google.com/p/go/issues/detail?id=7513#c16 to ...

10 years ago (2014-04-21 01:30:45 UTC) #3

minux1

10 years ago (2014-04-21 02:54:15 UTC) #4

R=close


On Sun, Apr 20, 2014 at 9:30 PM, <alex.brainman@gmail.com> wrote:

> On 2014/04/20 23:25:49, gobot wrote:
>
>> mailto:R=alex.brainman@gmail.com (assigned by
>>
> mailto:minux.ma@gmail.com)
>
> We have decided https://code.google.com/p/go/issues/detail?id=7513#c16
> to drop this change.
>
Didn't see that, sorry.

Expand All Messages | Collapse All Messages