Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(437)

Issue 7415051: code review 7415051: cmd/gc: disallow selectors to the blank identifier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by DMorsing
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: disallow selectors to the blank identifier Fixes issue 4941.

Patch Set 1 #

Patch Set 2 : diff -r b0c8d47acfc5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b0c8d47acfc5 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a565c143b41b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/cmd/gc/typecheck.c View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/blank1.go View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
DMorsing
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-03-02 19:04:57 UTC) #1
rsc
LGTM
12 years ago (2013-03-04 15:09:41 UTC) #2
DMorsing
12 years ago (2013-03-04 16:01:47 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7e8e7c4d187e ***

cmd/gc: disallow selectors to the blank identifier

Fixes issue 4941.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7415051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b